Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PackageVariantSet injector template #3952

Merged
merged 1 commit into from
May 11, 2023

Conversation

johnbelamaric
Copy link
Contributor

Since the config injection feature of PackageVariant has been implemented, we need to extend PVS to support setting the injectors field in the PV.

@johnbelamaric johnbelamaric requested a review from a team as a code owner May 10, 2023 22:38
@johnbelamaric
Copy link
Contributor Author

@natasha41575 can you review please?

@SimonTheLeg, after your KRM PR merges, we'll need a PR similar to this to allow Pipeline in the PVS. For now, we can skip doing any CEL expressions for Pipeline, though, until we see a real need for it. So instead we would just use a static pipeline in the PVS.

The only real CEL usage I can imagine wanting in the future for Pipeline would be for function.configMap to become a MapExpr instead of a map[string]string. It's going to be a bit painful, because your template basically has to clone the whole Pipeline and just change the type of that one field. That's why I think it could wait until we see a real need. We already can muck with Package Context which can be a config map input to a function...though it's limited to just one and has certain reserved fields already.

@johnbelamaric johnbelamaric merged commit fca5a91 into kptdev:main May 11, 2023
johnbelamaric added a commit to johnbelamaric/kpt that referenced this pull request May 12, 2023
johnbelamaric added a commit to mortent/kpt that referenced this pull request Sep 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants