Fix missing injectors field in PVS CRD #3956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
natasha41575
approved these changes
May 11, 2023
yuwenma
reviewed
May 11, 2023
| served: false | ||
| served: true |
There was a problem hiding this comment.
IIRC, this CRD is autogenerated by kubebuilder. So instead of changing the CRD itself, we should make the inline change so in the future when upgrading the CRD this config won't be flipped back.
Basically adding +kubebuilder:storageversion in https://github.com/GoogleContainerTools/kpt/blob/fca5a9170de2808197789e6ef5ff384ca67a7dd4/porch/controllers/packagevariants/api/v1alpha1/packagevariant_types.go#L21
@johnbelamaric
There was a problem hiding this comment.
Thanks! I will fix that.
johnbelamaric
added a commit
to johnbelamaric/kpt
that referenced
this pull request
May 12, 2023
johnbelamaric
added a commit
to mortent/kpt
that referenced
this pull request
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like I left this out of the recent PR.