render: allows functions to access network during pipeline execution #4007
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mortent
approved these changes
Jul 17, 2023
natasha41575
approved these changes
Jul 18, 2023
johnbelamaric
pushed a commit
to mortent/kpt
that referenced
this pull request
Sep 18, 2023
…ptdev#4007) * render: allows functions to access network during pipeline execution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this PR,
kpt rendersupports a commandline flag--allow-networkthat allows functions to access network during pipeline execution.# an example $ kpt fn render --allow-networkRegarding testing: add configuration in the end to end test runner and exercised the new flag in one of the existing tests.
Note that the docs/help text will be added in the follow up PR because docs are merged post the
kptrelease.