Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump cli-utils #4011

Merged
merged 3 commits into from
Jul 26, 2023
Merged

chore: bump cli-utils #4011

merged 3 commits into from
Jul 26, 2023

Conversation

sdowell
Copy link
Contributor

@sdowell sdowell commented Jul 24, 2023

Several fixes have been made in cli-utils that we would like to incorporate downstream. This requires also bumping some of the shared dependencies, such as k8s apis.

Several fixes have been made in cli-utils that we would like to
incorporate downstream. This requires also bumping some of the shared
dependencies, such as k8s apis.
@sdowell sdowell marked this pull request as ready for review July 24, 2023 23:22
@sdowell sdowell requested a review from a team as a code owner July 24, 2023 23:22
@sdowell sdowell requested a review from yuwenma July 24, 2023 23:22
Upgrading cli-utils in kpt means also upgrading it for Porch. The
cli-utils upgrade requires a k8s api upgrade, which in turn requires an
open telemetry library upgrade. The previous open telemetry library
being used was pre-GA, thus the API has had breaking changes.
@mortent
Copy link
Contributor

mortent commented Jul 26, 2023

Looks like the last run succeeded. If you remove any logging that we don't want to submit, we can try to get this merged.

@sdowell sdowell merged commit bdb1e42 into kptdev:main Jul 26, 2023
15 checks passed
johnbelamaric pushed a commit to mortent/kpt that referenced this pull request Sep 18, 2023
* chore: bump cli-utils

Several fixes have been made in cli-utils that we would like to
incorporate downstream. This requires also bumping some of the shared
dependencies, such as k8s apis.

* chore: bump dependencies in porch

Upgrading cli-utils in kpt means also upgrading it for Porch. The
cli-utils upgrade requires a k8s api upgrade, which in turn requires an
open telemetry library upgrade. The previous open telemetry library
being used was pre-GA, thus the API has had breaking changes.

* NOT FOR MERGE - add CI debug logging
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants