Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix release script by removing release targets that require CGO #4014

Merged
merged 1 commit into from
Aug 2, 2023

Conversation

mortent
Copy link
Contributor

@mortent mortent commented Aug 2, 2023

This fixes the release process by removing the release targets that require CGO, in practice these are the WASM targets. There are two reasons for this:

  • The complexity of the kpt release process is much higher because of the need to compile with CGO, as we are using ghcr.io/goreleaser/goreleaser-cross and do builds within docker containers on Github Actions. This process is currently broken, and this is a fix that addresses the immediate issue and simplifies the process for the future.
  • The ghcr.io/goreleaser/goreleaser-cross image tends to be a bit slow to pick up new Go versions, which makes it hard for us to quickly get out new versions of kpt when there are CVEs in go.

Both of these issues can be fixed, but it requires some effort to figure out how to do it right.

@mortent mortent requested a review from a team as a code owner August 2, 2023 19:32
@mortent mortent requested a review from justinsb August 2, 2023 19:32
@droot
Copy link
Contributor

droot commented Aug 2, 2023

Can we document instructions for users (in a Github Issue) to build their own kpt binary from a tag with CGO so that users who depend on WASM knows what to do in absence of the WASM release artifacts.

@mortent mortent merged commit 5108bca into kptdev:main Aug 2, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants