Move resource version annotation to a different file #4018
Conversation
bharat-m1
force-pushed
the
kpt-meta-data
branch
2 times, most recently
from
3295ee5
to
609bfb3
Compare
|
The commit hash will change every run, so you probably need to tweak the test code to strip those out before doing deltas. Timestamp too. I had to do that with the prior version. You may also want to not store all the annotations (in the actual code, not the test code), but I didn't mention it before because it's harmless that they are there; they are ignored by your |
Additional things I can find are creationTimestamp & uid. Instead of removing specific annotations, I hope we can dump them only. As we have made it a hidden file it should not affect the user too. |
bharat-m1
force-pushed
the
kpt-meta-data
branch
from
609bfb3
to
f4f4c31
Compare
bharat-m1
force-pushed
the
kpt-meta-data
branch
from
f4f4c31
to
793a874
Compare
commands/alpha/rpkg/pull/command.go
Outdated
| @@ -113,7 +113,7 @@ func (r *runner) runE(_ *cobra.Command, args []string) error { | |||
| return errors.E(op, err) | |||
| } | |||
|
|
|||
| if err := util.AddResourceVersionAnnotation(&resources); err != nil { | |||
| if err := util.AddRevisionMetaData(&resources); err != nil { | |||
There was a problem hiding this comment.
Nit: We should use consistent naming, so this should probably be AddRevisionMetadata.
bharat-m1
force-pushed
the
kpt-meta-data
branch
from
793a874
to
5d2b47e
Compare
The newly added file can be used for storing all the metadata going forward It is added and removed from the client side and will not be present in porch Please refer this for more info: kptdev#4017
bharat-m1
force-pushed
the
kpt-meta-data
branch
from
5d2b47e
to
faaf95b
Compare
The newly added file can be used for storing all the metadata going forward It is added and removed from the client side and will not be present in porch Please refer this for more info: kptdev#4017
Moving resource version annotation to a new file. The newly added file can be used for storing all the metadata going forward. It is added and removed from the client side and will not be present in porch.
Please refer this for more info: #4017