Fix: Throw error while rejecting a package which is not proposed/deletion-proposed #4022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
proposed/deletion-proposed
johnbelamaric
approved these changes
Aug 15, 2023
mortent
approved these changes
Aug 15, 2023
| @@ -158,6 +158,9 @@ commands: | |||
| - --namespace=rpkg-lifecycle | |||
| stderr: | | |||
| cannot reject git-017a8366a5e0d9b35ae6dc489d4d3f68046d6034 with lifecycle 'Published' | |||
| Error: errors: | |||
There was a problem hiding this comment.
This output is a bit awkward, but it isn't really due to this PR. We should fix that in a separate PR.
johnbelamaric
pushed a commit
to mortent/kpt
that referenced
this pull request
Sep 18, 2023
proposed/deletion-proposed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Default case of switch should throw an error response while rejecting a package.