Run Porch as non-root #4028
Run Porch as non-root #4028
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
/retest |
|
@adetalhouet you probably need to make similar changes to the deployment manifests produced by the Porch build process as you did in the Nephio repo. The manifests in the Nephio repo are just a subset of the ones generated here. Right now, e2e tests are failing, likely because the manifests used to install Porch here do not have those changes. |
- Specify where the api certs should be stored, under a path not required root access. - Customize the api server port to not use a non-priviledge port as targetPort Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
There was a problem hiding this comment.
the change itself LGTM and I think it makes sense to do this, but I think we should make sure @mortent agrees before merging
* Run Porch as non-root * Remove elevated permissions requirements - Specify where the api certs should be stored, under a path not required root access. - Customize the api server port to not use a non-priviledge port as targetPort Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com> --------- Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
Create a
porchuser to run the porch-server as non-root.