GCP fleet sync controller #4043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnbelamaric
force-pushed
the
fleetsync
branch
from
dae845f
to
5529eb7
Compare
johnbelamaric
force-pushed
the
fleetsync
branch
2 times, most recently
from
874d159
to
8ee7e9e
Compare
Signed-off-by: John Belamaric <jbelamaric@google.com>
- Rename `spec` to `data` since this is discovered data, not spec - Add resources for scopes and membership bindings - Add additional fields Signed-off-by: John Belamaric <jbelamaric@google.com>
Signed-off-by: John Belamaric <jbelamaric@google.com>
Signed-off-by: John Belamaric <jbelamaric@google.com>
Signed-off-by: John Belamaric <jbelamaric@google.com>
johnbelamaric
force-pushed
the
fleetsync
branch
from
8ee7e9e
to
901d156
Compare
Signed-off-by: John Belamaric <jbelamaric@google.com>
Signed-off-by: John Belamaric <jbelamaric@google.com>
johnbelamaric
changed the title
|
@mortent I think this is ready for a look, at least, if not merging. It now syncs fleet memberships, scopes, and membership bindings. I don't sync fleet namespaces or RBAC bindings at this time. We can probably refactor to make less code duplication between types, but I think it's OK for now. |
mortent
approved these changes
Sep 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated version of #3944