Clean up repo cache when repository is removed #4049
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Morten Torkildsen <mortent@google.com>
mortent
force-pushed
the
CleanUpRepoCaches
branch
from
c1e33db
to
7236eda
Compare
johnbelamaric
approved these changes
Sep 23, 2023
natasha41575
approved these changes
Sep 26, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes an issue where the git cache on the local filesystem does not get clean up when a repository is removed. This means that if the same repo is later added again, the local cache will be used, even if it might be stale at that point.
The fix here adds logic for checking if an underlying repo is used by several Porch repositories by listing the existing repositories known to Porch. It will only clean up a repo if it is not being shared. And when it gets cleaned up, it will make sure to also delete the local cache.