fix: Avoid panic when inventory update errors #4055
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also avoid losing modifications due to mutating webhooks. Signed-off-by: Karl Isenberg <karlisenberg@google.com>
karlkfi
force-pushed
the
karl-fix-live-provider-panic
branch
from
7aa0f24
to
e84f326
Compare
sdowell
approved these changes
Oct 6, 2023
|
|
||
| // Update status. | ||
| // Update status, if status policy allows it. |
There was a problem hiding this comment.
Some unit tests here would be nice to have if it's not too cumbersome
There was a problem hiding this comment.
Adding unit tests would require faking the dynamic.Interface and meta.RESTMapper. The fakes I wrote are in kpt-config-sync downstream, which make them hard to use here. If we want to use the fake clients in kpt, we'll have to upstream the fakes into cli-utils first.
So adding unit tests might be more effort than it's worth at this point.
mortent
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix two bugs in the inventory provider: