Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revise locking strategy #4087

Merged
merged 6 commits into from
Nov 21, 2023
Merged

Revise locking strategy #4087

merged 6 commits into from
Nov 21, 2023

Commits on Nov 20, 2023

  1. Revise locking strategy 

    Signed-off-by: John Belamaric <jbelamaric@google.com>
    @johnbelamaric
    johnbelamaric committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    547eedb View commit details
    Browse the repository at this point in the history

  2. Lock when checking for nil 

    Signed-off-by: John Belamaric <jbelamaric@google.com>
    @johnbelamaric
    johnbelamaric committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    b414ff3 View commit details
    Browse the repository at this point in the history

  3. Protect error read with the RLock too 

    Signed-off-by: John Belamaric <jbelamaric@google.com>
    @johnbelamaric
    johnbelamaric committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    bd723e0 View commit details
    Browse the repository at this point in the history

  4. First list no longer immediately triggers fetch, need to wait for the… 

    … poll

Signed-off-by: John Belamaric <jbelamaric@google.com>
    @johnbelamaric
    johnbelamaric committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    86a3a16 View commit details
    Browse the repository at this point in the history

  5. Before starting a new watcher, reap dead ones 

    Signed-off-by: John Belamaric <jbelamaric@google.com>
    @johnbelamaric
    johnbelamaric committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    5d62251 View commit details
    Browse the repository at this point in the history

  6. Fix problem with function repos not loading 

    Signed-off-by: John Belamaric <jbelamaric@google.com>
    @johnbelamaric
    johnbelamaric committed Nov 20, 2023
    Configuration menu
    Copy the full SHA
    39e932d View commit details
    Browse the repository at this point in the history