Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update controller-tools to 0.14.0 #4134

Merged
merged 4 commits into from
Mar 29, 2024

Conversation

justinsb
Copy link
Contributor

@justinsb justinsb commented Mar 28, 2024

Older versions of controller-tools panic with newer go versions.

Also update stringer; it also panics.

@justinsb justinsb force-pushed the update_go_generate branch 2 times, most recently from 84e8506 to 7756cea Compare March 28, 2024 17:23
Older versions of controller-tools panic with newer go versions.

Signed-off-by: justinsb <justinsb@google.com>
Specifying object multiple times is now an error.

Signed-off-by: justinsb <justinsb@google.com>
We need a newer version to avoid panics with newer go versions, and
this should also be versioned independently from go.mod

Signed-off-by: justinsb <justinsb@google.com>
Signed-off-by: justinsb <justinsb@google.com>
@justinsb
Copy link
Contributor Author

/assign @droot

@justinsb justinsb merged commit 08e38cb into kptdev:main Mar 29, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants