Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove meta-tags.gemspec and Rakefile from the gem package #312

Merged
merged 1 commit into from
Sep 14, 2024

Conversation

kpumuk
Copy link
Owner

@kpumuk kpumuk commented Sep 14, 2024

Bunlding gemspec does not make much sense since it is only used in development to produce metadata, added to the gem package as a YAML-serialized Gem::Specification. Additionally, Rakefile is also removed, as it is only used in development.

File list difference

To test, I built the gem with rake build and compared the listing before and after the change:

tar -xOzf pkg/meta-tags-2.22.0.gem data.tar.gz | tar -tzf -

Full diff:

--- before.txt	2024-09-13 20:39:38
+++ after.txt	2024-09-13 20:39:29
@@ -3,7 +3,6 @@
 CONTRIBUTING.md
 MIT-LICENSE
 README.md
-Rakefile
 certs/kpumuk.pem
 lib/generators/meta_tags/install_generator.rb
 lib/generators/meta_tags/templates/config/initializers/meta_tags.rb
@@ -19,7 +18,6 @@
 lib/meta_tags/text_normalizer.rb
 lib/meta_tags/version.rb
 lib/meta_tags/view_helper.rb
-meta-tags.gemspec
 sig/lib/_internal/rails.rbs
 sig/lib/meta_tags.rbs
 sig/lib/meta_tags/configuration.rbs

@kpumuk kpumuk merged commit f18e832 into main Sep 14, 2024
50 checks passed
@kpumuk kpumuk deleted the gemspec-gem-pkg branch September 14, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant