Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add the TypeScript code and docs for Chapter of Linear Search #216

Merged
merged 8 commits into from
Jan 11, 2023
Merged

Add the TypeScript code and docs for Chapter of Linear Search #216

merged 8 commits into from
Jan 11, 2023

Conversation

danielsss
Copy link
Contributor

@danielsss danielsss commented Jan 7, 2023 •
edited
Loading

added: linear_search.ts and arrToLinkedList function
updated: linear search docs for Typescript

  • I've tested the code and ensured the outputs are the same as the outputs of reference codes.
  • I've checked the codes (formatting, comments, indentation, file header, etc) carefully.
  • The code does not rely on a particular environment or IDE and can be executed on a standard system (Win, macOS, Ubuntu).

@vercel
Copy link

vercel bot commented Jan 7, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
hello-algo ⬜️ Ignored (Inspect) Jan 10, 2023 at 10:46AM (UTC)

krahets
krahets reviewed Jan 8, 2023
View reviewed changes
.editorconfig Outdated
@@ -0,0 +1,14 @@
# EditorConfig is awesome: https://EditorConfig.org
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an editor-related file or a language-related file?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just an editor-related file.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Please remove it. We should not keep any editor-related files in the repo.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

krahets
krahets reviewed Jan 8, 2023
View reviewed changes
Copy link
Owner

@krahets krahets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Waiting the final review by @justin-tse

@danielsss danielsss requested a review from krahets January 10, 2023 10:46
justin-tse
justin-tse approved these changes Jan 11, 2023
View reviewed changes
Copy link
Contributor

@justin-tse justin-tse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank @danielsss for the clean codes!

@justin-tse justin-tse mentioned this pull request Jan 11, 2023
Closed
52 tasks
@krahets krahets merged commit 7a38139 into krahets:master Jan 11, 2023
@krahets krahets added the code Code-related label Jan 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krahets krahets krahets approved these changes

@justin-tse justin-tse justin-tse approved these changes

Assignees
No one assigned
Labels
code Code-related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@danielsss @justin-tse @krahets