Embed json schema in the binary #34
Open
+188
−188
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dhontecillas
approved these changes
Dec 20, 2024
check.go
Outdated
Comment on lines
196
to
200
| if err != nil { | ||
| return nil, err | ||
| } | ||
|
|
||
| return body, resp.Body.Close() |
There was a problem hiding this comment.
I am not sure about this, but either we add a resp.Body.Close() before line 197, or we do not need to call resp.Body.Close() in line 200, no ? Does jsonschema.UnmarshalJSON call Close itself?
There was a problem hiding this comment.
UnmarshalJSON does not close the reader, but it's true that we should close it if there's an error
cmd.go
Outdated
| Cmd *cobra.Command | ||
| Flags []FlagBuilder | ||
| once *sync.Once | ||
| Constraints []ContraintBuilder |
There was a problem hiding this comment.
nittypicky: ContraintBuilder is missing an s -> ConstraintBuilder.
thedae
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new ways to lint the config file
Embed schema
Use
cmd.NewCheckCmd(schema)when building the root command to embed a json schema in string format.Spawn the
krakend checkcommand with a-n|--lint-no-networklint against itCustom schema
Spawn the
krakend checkcommand with a-s|--lint-schema [url|path]to lint against a custom URL or local file--lint,--lint-no-networkand--lint-schemaflags are mutually exclusiveℹ️ This PR bumps
jsonschemadependency tov6and cobra tov1.8.1