Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix spelling in docs #237

Merged
merged 1 commit into from
Feb 19, 2025
Merged

Conversation

Jonher937
Copy link
Contributor

I've done my best to map each word to what I think it should say.

There might be some UK <-> US differences that Cspell caught, feel free to edit if something is not to satisfaction.

I have not updated the date in each md since the content has not changed, just the spelling mistakes.

@alombarte
Copy link
Member

alombarte commented Feb 18, 2025

Thank you, @Jonher937, for this contribution; I love it! A bunch of typos that were piling up over the years are now fixed. The documentation should all use the US spelling, but we might have also introduced inconsistencies over time.
Thanks for this!

Could you please sign the commit so we can merge it?
git commit -S

@Jonher937
Copy link
Contributor Author

I do not have a gpg keys for git usage and rather strange requirement for a docs repo.
Feel free to amend the commit and edit the author to sign it with an appropriate identity.

@taik0
Copy link
Member

taik0 commented Feb 18, 2025

Hi @Jonher937 , a SSH key also works for commit signing.

@Jonher937
Copy link
Contributor Author

Feel free to amend the commit and edit the author to sign it with an appropriate identity.

Even after adding the key it GitHub, setting up the local git options, executing git commit -S --amend does not sign the commit. It's not worth signing a commit for a docs repo that has no code.

Feel free to export this PR as a diff and commit accoring to your repo rules. I don't need the credit, just don't like typos while reading docs 😃

@alombarte alombarte merged commit d7f1c91 into krakend:master Feb 19, 2025
@alombarte
Copy link
Member

Hi @Jonher937, this is the sad world of compliance and certifications we live in 😞 ... We have disabled the signing requirement for the documentation. Thanks for your contribution!

@Jonher937 Jonher937 deleted the spelling-in-docs branch February 19, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants