Add new iPhone Models to screenHeights.js #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsbrunson
approved these changes
Oct 11, 2022
|
@spencersablan Also need to add iPhone 14 Pro Max. It has an outerHeight of 932. |
|
@spencersablan Can you also add iPhone 14 to the 844 section description? Here is a good link to make sure we are updated across the board. https://useyourloaf.com/blog/iphone-14-screen-sizes/ |
mnicpt
reviewed
Oct 12, 2022
|
@spencersablan Nice work by the way! This is not a fun task. |
mnicpt
reviewed
Oct 12, 2022
Co-authored-by: Steven Mask <mnicpt@gmail.com>
|
@mnicpt Thank you for all your help & input! 😄 Yesterday, I went through & test every device that is iOS 16 compatible for whether or not the Venmo button is displaying as expected. I'll add my results below just so we are all on the same page. Interesting that, besides the new iPhones, we didn't have any that didn't show up in the Safari browser. Action steps for myself today:
|
|
@spencersablan Nice work! |
westeezy
pushed a commit
that referenced
this pull request
Oct 13, 2022
* fix: add new iphone models to screenheights.js * fix: add iphone 14 Co-authored-by: Steven Mask <mnicpt@gmail.com> * fix: add iphone 14 pro max to screenheights.js * fix: fix 1x safari browser overlap on iphone 14 pro * fix: add iphone 12 mini specs * fix: remove extra data for minis Co-authored-by: Steven Mask <mnicpt@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
screenHeights.jssince the Venmo button was not showing up on that device.Conversation