feat: input files on keys #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds a '-k' option that loads onto a key the data from a given file.
sto
force-pushed
the
feat/input-files-on-keys
branch
from
eb64864
to
1e6f586
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR includes my previous fix to return 1 on errors and adds a new input flag to allow loading data on a variable; this allows reading a file that contains something that is not a dict (in the example I use a list) and is useful to read multiple versions of the same input on different keys (that's why I wanted the feature on the first place).
As I'm using
vim-goas my IDE and it uses tools to lint and improve code I've also applied changes to remove warnings (i.e. use functions onioorosmodules instead ofio/ioutiland some other style changes like using snakeCase names for variables).