fix(controller): fix index out of range on some usage of fromChart() (a…

…kuity#2998) Signed-off-by: Kent Rancourt <kent.rancourt@gmail.com>
krancour · Nov 26, 2024 · ac18cc2 · ac18cc2
1 parent a8757d4
commit ac18cc2
Show file tree

Hide file tree

Showing 2 changed files with 390 additions and 135 deletions.
diff --git a/internal/directives/promotions.go b/internal/directives/promotions.go
@@ -142,8 +142,8 @@ func (s *PromotionStep) GetConfig(
 		expr.Function(
 			"commitFrom",
 			getCommitFunc(ctx, cl, promoCtx),
-			new(func(repoURL string) kargoapi.GitCommit),
 			new(func(repoURL string, origin kargoapi.FreightOrigin) kargoapi.GitCommit),
+			new(func(repoURL string) kargoapi.GitCommit),
 		),
 		expr.Function(
 			"imageFrom",
@@ -154,10 +154,10 @@ func (s *PromotionStep) GetConfig(
 		expr.Function(
 			"chartFrom",
 			getChartFunc(ctx, cl, promoCtx),
-			new(func(repoURL string) kargoapi.Chart),
+			new(func(repoURL string, chartName string, origin kargoapi.FreightOrigin) kargoapi.Chart),
 			new(func(repoURL string, chartName string) kargoapi.Chart),
 			new(func(repoURL string, origin kargoapi.FreightOrigin) kargoapi.Chart),
-			new(func(repoURL string, chartName string, origin kargoapi.FreightOrigin) kargoapi.Chart),
+			new(func(repoURL string) kargoapi.Chart),
 		),
 	)
 	if err != nil {