Skip to content
This repository has been archived by the owner on May 12, 2020. It is now read-only.

"Reviewer" option should only style the GUI parts #38

Closed
twwn opened this issue Jun 11, 2018 · 3 comments
Closed

"Reviewer" option should only style the GUI parts #38

twwn opened this issue Jun 11, 2018 · 3 comments

Comments

@twwn
Copy link

twwn commented Jun 11, 2018

Right now the "Reviewer" option in "choose what to style" will also cause the webview (ie. cards themselves) to be styled.

Pretty sure that's not what you intended as it's what the "Anki Web View" option seems for: That one doesn't seem to affect the GUI, and the latter has no separate option.

@krassowski
Copy link
Owner

Agreed, that is a bit counter-intuitive.

However some other styler than "Anki Web View" should take this responsibility: Anki web view is used in too many places (like deck browser, overview etc) and it would not be possible for me to test all the combinations. In fact, it is meant to only apply the styles in some rare states, when no other components could be easily monkeypatched and styled. Again, it is highly intertwined and enabling it the web view styling will make other options less useful.

@krassowski
Copy link
Owner

I developed a fix (see this branch) which adds "Reviewer Cards" styler which takes responsibility for the webview for reviewer only. It will allow you to style cards and other parts of the GUI separately.

I am going to release the fix on the weekend.

krassowski added a commit that referenced this issue Jun 12, 2018
Move cards styling into a separate styler #38
@krassowski
Copy link
Owner

Fix was included in the 2.1.7 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants