Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: repo must be null when helm is in OCI #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

cristian98149
Copy link

If repo parameter is not set to null when using helm in oci, the following error is reported:

Status:
  Conditions:
    Last Transition Time:  2024-10-18T08:16:59Z
    Message:               cannot update object: CompositionDefinition.core.krateo.io "smartroadsapp" is invalid: spec.chart: Invalid value: "object": Repo is required once set

Setting "repo: null" in values.yaml file used when installing compositiondefinition chart resolve this issue.

Signed-off-by: Cristian Bonanno <47886306+cristian98149@users.noreply.github.com>
@cristian98149 cristian98149 changed the title fix: repo must be null when helm is is oci fix: repo must be null when helm is in OCI Oct 18, 2024
@braghettos
Copy link
Member

You probably tried to install the chart with the spec.chart.repo key, but you wanted to remove it later. If this is the case, we have the following validation rule: https://github.com/krateoplatformops/core-provider-chart/blob/main/chart/crds/core.krateo.io_compositiondefinitions.yaml#L117-L118 where we remove the possibility to change this value after defining it.

@cristian98149
Copy link
Author

The error appeared with 'repo: ""'. We didn't try to remove it later once created.

Signed-off-by: Cristian Bonanno <47886306+cristian98149@users.noreply.github.com>
@braghettos
Copy link
Member

@cristian98149 can you please attach the values.yaml file of your chart?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants