Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Python 3.12 #66

Closed
declension opened this issue Oct 9, 2023 · 2 comments · Fixed by #67
Closed

Support Python 3.12 #66

declension opened this issue Oct 9, 2023 · 2 comments · Fixed by #67

Comments

@declension
Copy link

declension commented Oct 9, 2023 •
edited
Loading

First of all, thanks for the library, very useful!

Python 3.12 is now out 🎉

In upgrading our CI matrix build to support this, we got breakage due to lack of libmagic again. Presumably this is now due to failing to install the pylibmagic wheel which doesn't exist at 0.4.0?

Could we add 3.12 to the build matrix? Happy to have a go at a PR if that helps
@kratsg kratsg mentioned this issue Oct 10, 2023
Merged
@kratsg
Copy link
Owner

kratsg commented Oct 19, 2023

Try v0.5.0 and see if that works.

@declension
Copy link
Author

Try v0.5.0 and see if that works.

Works like a charm - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add 3.12 to support kratsg/pylibmagic
2 participants
@kratsg @declension