Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add 3.12 to support #67

Merged
merged 4 commits into from
Oct 19, 2023
Merged

feat: Add 3.12 to support #67

merged 4 commits into from
Oct 19, 2023

Conversation

kratsg
Copy link
Owner

@kratsg kratsg commented Oct 10, 2023

Resolves #66.

@kratsg
Copy link
Owner Author

kratsg commented Oct 10, 2023

@henryiii i'm going to need your help, It's not obvious to me whether I should rebuild for 3.12 specifically, since apparently cp310-* covered 3.11 and below when building -- do you know what i should be doing to make sure I have support for 3.7 to 3.12? (3.7 is needed sadly).

@henryiii
Copy link
Collaborator

cp310-* only builds 3.10. What are you looking at? cibuildwheel should be able to build 3.6-3.12 if you needed it.

@henryiii
Copy link
Collaborator

Ah, this is not version specific, you don't use the CPython API. That's why you are picking a version. Version doesn't matter, it's not Python version specific. Did you try it on 3.12?

@henryiii
Copy link
Collaborator

Ahh, I think we moved to scikit-build-core, and now it only produces one wheel for all Python versions, while before it made one per version, correct?

@henryiii
Copy link
Collaborator

I think all you need now is a new release. Python version doesn't matter anymore.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
@declension
Copy link

This looks good. Any timelines for getting it merged? 🙏

@kratsg
Copy link
Owner Author

kratsg commented Oct 19, 2023

This looks good. Any timelines for getting it merged? 🙏

Today-ish. I was checking some other stuff with downstream (internal) libs that need this before I merge it in.

@kratsg kratsg merged commit 935befa into main Oct 19, 2023
9 checks passed
@kratsg kratsg deleted the feat/python312 branch October 19, 2023 20:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Python 3.12
3 participants