-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add 3.12 to support #67
Conversation
@henryiii i'm going to need your help, It's not obvious to me whether I should rebuild for 3.12 specifically, since apparently |
|
Ah, this is not version specific, you don't use the CPython API. That's why you are picking a version. Version doesn't matter, it's not Python version specific. Did you try it on 3.12? |
Ahh, I think we moved to scikit-build-core, and now it only produces one wheel for all Python versions, while before it made one per version, correct? |
I think all you need now is a new release. Python version doesn't matter anymore. |
This looks good. Any timelines for getting it merged? 🙏 |
Today-ish. I was checking some other stuff with downstream (internal) libs that need this before I merge it in. |
Resolves #66.