results for chrome 126

krausest · Jun 15, 2024 · 34e0337 · 34e0337
1 parent 274d3aa
commit 34e0337
Show file tree

Hide file tree

Showing 6 changed files with 217 additions and 276 deletions.
diff --git a/webdriver-ts-results/src/App.tsx b/webdriver-ts-results/src/App.tsx
@@ -48,7 +48,7 @@ const App = () => {
 
   const testEnvironmentInfo = (
     <p>
-      The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 125.0.6422.60
+      The benchmark was run on a MacBook Pro 14 (32 GB RAM, 8/14 Cores, OSX 14.4), Chrome for Testing 126.0.6478.55
       (arm64) using the puppeteer benchmark driver with reduced tracing.
     </p>
   );

diff --git a/webdriver-ts-results/src/results.ts b/webdriver-ts-results/src/results.ts
diff --git a/webdriver-ts/chromePreferences.json b/webdriver-ts/chromePreferences.json
diff --git a/webdriver-ts/results.json b/webdriver-ts/results.json
diff --git a/webdriver-ts/src/benchmarkRunner.ts b/webdriver-ts/src/benchmarkRunner.ts
@@ -71,53 +71,6 @@ function forkAndCallBenchmark(
   });
 }
 
-async function runBenchmakLoopStartup(
-  framework: FrameworkData,
-  benchmarkInfo: StartupBenchmarkInfo,
-  benchmarkOptions: BenchmarkOptions
-): Promise<{ errors: string[]; warnings: string[] }> {
-  let warnings: string[] = [];
-  let errors: string[] = [];
-
-  let results: Array<StartupBenchmarkResult> = [];
-  let count = benchmarkOptions.numIterationsForStartupBenchmark;
-  benchmarkOptions.batchSize = 1;
-
-  let retries = 0;
-  let done = 0;
-
-  console.log("runBenchmakLoopStartup", framework, benchmarkInfo);
-
-  while (done < count) {
-    console.log("FORKING:", benchmarkInfo.id, "BatchSize", benchmarkOptions.batchSize);
-    let res = await forkAndCallBenchmark(framework, benchmarkInfo, benchmarkOptions);
-    if (Array.isArray(res.result)) {
-      results = results.concat(res.result as StartupBenchmarkResult[]);
-    } else {
-      results.push(res.result);
-    }
-    if (res.warnings) {
-      warnings = warnings.concat(res.warnings);
-    }
-    if (res.error) {
-      errors.push(`Executing ${framework.uri} and benchmark ${benchmarkInfo.id} failed: ` + res.error);
-      break;
-    }
-    done++;
-  }
-  if (config.WRITE_RESULTS) {
-    await writeResults(benchmarkOptions.resultsDirectory, {
-      framework: framework,
-      benchmark: benchmarkInfo,
-      results: results,
-      type: BenchmarkType.STARTUP,
-    });
-  }
-  return { errors, warnings };
-  // } else {
-  //     return executeBenchmark(frameworks, keyed, frameworkName, benchmarkName, benchmarkOptions);
-}
-
 async function runBenchmakLoopSize(
   framework: FrameworkData,
   benchmarkInfo: SizeBenchmarkInfo,
@@ -252,13 +205,7 @@ async function runBench(
       try {
         let result;
 
-        if (benchmarkInfos[j].type == BenchmarkType.STARTUP_MAIN) {
-          result = await runBenchmakLoopStartup(
-            runFrameworks[i],
-            benchmarkInfos[j] as StartupBenchmarkInfo,
-            benchmarkOptions
-          );
-        } else if (benchmarkInfos[j].type == BenchmarkType.SIZE_MAIN) {
+        if (benchmarkInfos[j].type == BenchmarkType.SIZE_MAIN) {
           result = await runBenchmakLoopSize(
             runFrameworks[i],
             benchmarkInfos[j] as SizeBenchmarkInfo,

diff --git a/webdriver-ts/src/puppeteerAccess.ts b/webdriver-ts/src/puppeteerAccess.ts
@@ -133,7 +133,6 @@ export async function startBrowser(benchmarkOptions: BenchmarkOptions): Promise<
   const browser = await puppeteer.launch({
     headless: false,
     executablePath: browserPath(benchmarkOptions),
-
     args,
     dumpio: false,
     defaultViewport: {