Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Messaging: Add check if HTTP/2 is supported #903

Closed
wants to merge 1 commit into from
Closed

Conversation

jeromegamez
Copy link
Member

Fixes #888, kreait/laravel-firebase#219

As reported in the issues above, environments that don't have at least cURL 7.47 (released in 2016) installed, seem unable to send FCM Messages since Release 7.10.0 of the SDK.

This PR tries to address this.

:octocat:

Copy link

codecov bot commented May 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.10%. Comparing base (1ef4b1e) to head (fa62686).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff            @@
##                7.x     #903   +/-   ##
=========================================
  Coverage     91.10%   91.10%           
- Complexity     1583     1585    +2     
=========================================
  Files           156      156           
  Lines          4416     4416           
=========================================
  Hits           4023     4023           
  Misses          393      393           

@jeromegamez
Copy link
Member Author

This apparently wasn't it 😅

@jeromegamez jeromegamez deleted the http2 branch May 31, 2024 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to send messaging after updating to 7.10.0
1 participant