Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API docs | Docs screenshots | Refactor rescaling | Rearrange widgets #249

Merged
merged 21 commits into from
May 31, 2024

Conversation

lorenzocerrone
Copy link
Collaborator

@lorenzocerrone lorenzocerrone commented May 26, 2024

This PR includes

  • first draft of the Python-API documentation
  • some minor structure changes
  • Rearrange tabs in napari #246
  • GUI video-docs POSTPONED
  • new rescaling widget with docs
  • auto screenshots for documentation with light/dark theme

Copy link
Collaborator

@qin-yu qin-yu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I skimmed through the changes and marked whatever I felt suspicious. Didn't really check line by line, but looks great!

mkdocs.yml Outdated Show resolved Hide resolved
mkdocs.yml Show resolved Hide resolved
@lorenzocerrone lorenzocerrone marked this pull request as ready for review May 29, 2024 13:43
@lorenzocerrone
Copy link
Collaborator Author

Let's merge it as it is now. This PR It's getting to big and too long. I will finish the docs in a next PR

@qin-yu
Copy link
Collaborator

qin-yu commented May 29, 2024

Yeah I also think this went over the scope of this PR already. If you don't need me to check anything then just merge it.

@lorenzocerrone
Copy link
Collaborator Author

I would like you to check the new rescaling widget

@qin-yu
Copy link
Collaborator

qin-yu commented May 29, 2024

I read the rescaling parts of changes and launched PlantSeg to see it. It looks great, and I think

  1. As long the rescaling functionalities are documented, such as the difference between To voxel size and Set voxel size, then all good
  2. To test these, maybe it's better to also write tests for them? It shouldn't rely on us clicking the widget 7 times to test each functions
  3. It is only a temporary solution to suppress warning with # type: ignore

I can do 2 and 3 if you don't have time for it.

@lorenzocerrone
Copy link
Collaborator Author

Yes it would be great if we you could do 2 and 3. Yeah I will document it all

@qin-yu
Copy link
Collaborator

qin-yu commented May 29, 2024

I feel it make sense to have "Set voxel size" here, but it's still confusing before users read the docs. It is a very useful thing to have and I need it, but I don't know where to put either. If you thought about it already then let's just leave it there.

@lorenzocerrone
Copy link
Collaborator Author

I feel it make sense to have "Set voxel size" here, but it's still confusing before users read the docs. It is a very useful thing to have and I need it, but I don't know where to put either. If you thought about it already then let's just leave it there.

The alternative would be to put it in the IO tab as a stand alone widget.

@qin-yu
Copy link
Collaborator

qin-yu commented May 29, 2024

I was thinking if we could merge all changes up to ff3d714 and move the later commits into another PR and work there, but then realised the later commits are kind of related. Since you are done with the planed documentation update in this PR, let's rename and merge it before it includes everything.

Yes it would be great if we you could do 2 and 3. Yeah I will document it all

The alternative would be to put it in the IO tab as a stand alone widget.

I'll do these in the next one.

@qin-yu qin-yu changed the title Python api docs Create API docs | Rearrangement GUI | Refactor rescaling widget May 29, 2024
@qin-yu qin-yu added documentation Improvements or additions to documentation enhancement New feature or request GUI Napari GUI related labels May 29, 2024
@qin-yu qin-yu changed the title Create API docs | Rearrangement GUI | Refactor rescaling widget Create API docs | Refactor rescaling widget | Rearrange GUI May 29, 2024
@qin-yu qin-yu changed the title Create API docs | Refactor rescaling widget | Rearrange GUI API docs | Docs screenshots | Refactor rescaling | Rearrange widgets May 31, 2024
@qin-yu qin-yu merged commit 76d0fd9 into master May 31, 2024
1 check passed
@qin-yu qin-yu deleted the python-api-docs branch June 3, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request GUI Napari GUI related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants