-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
API docs | Docs screenshots | Refactor rescaling | Rearrange widgets #249
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the changes and marked whatever I felt suspicious. Didn't really check line by line, but looks great!
Let's merge it as it is now. This PR It's getting to big and too long. I will finish the docs in a next PR |
Yeah I also think this went over the scope of this PR already. If you don't need me to check anything then just merge it. |
I would like you to check the new rescaling widget |
I read the rescaling parts of changes and launched PlantSeg to see it. It looks great, and I think
I can do 2 and 3 if you don't have time for it. |
Yes it would be great if we you could do 2 and 3. Yeah I will document it all |
I feel it make sense to have "Set voxel size" here, but it's still confusing before users read the docs. It is a very useful thing to have and I need it, but I don't know where to put either. If you thought about it already then let's just leave it there. |
The alternative would be to put it in the IO tab as a stand alone widget. |
I was thinking if we could merge all changes up to ff3d714 and move the later commits into another PR and work there, but then realised the later commits are kind of related. Since you are done with the planed documentation update in this PR, let's rename and merge it before it includes everything.
I'll do these in the next one. |
This PR includes
GUI video-docsPOSTPONED