Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #452 from adalbertoteixeira/bugfix/add-core-js-dep…
…endency add required dependency core-js
- Loading branch information
79e5575There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think core-js is directly used in the project. Just doing an npm install installs core-js because it is a dependency of a dependency I guess..
Why do we need to put this specifically in package.json?
79e5575There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@inian it seems like many guys are bumping into this issue, this is hacky, yeah.. do you have a better solution?
79e5575There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its because they are using npm2 right?
#417
79e5575There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep
79e5575There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NPM, somehow installs this missing dependency in one of the referenced NPM packages. I don't know how :) And we don't know what NPM package causes this trouble yet.