Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

react-intl #609

Merged
merged 5 commits into from
Apr 22, 2016
Merged

react-intl #609

merged 5 commits into from
Apr 22, 2016

Conversation

langpavel
Copy link
Collaborator

No description provided.

@langpavel langpavel mentioned this pull request Apr 22, 2016
Closed
@langpavel
Copy link
Collaborator Author

langpavel commented Apr 22, 2016 •
edited
Loading

react-intl implementation.

  • enabled languages in configuration
  • extract messages from source automation, just run npm run extractMessages and all localizable strings apear in src/messages/ directory. In fact this is not needed. When you running development server, all messages are extracted and files watched
  • unused localization detection (tracking source files)
  • language negotiation:
    1. ?lang=xx query string parameter
    2. cookie
    3. request Accept-Language header
  • setLocale redux action - language live switching
  • graphql endpoint for fetching localization messages

@langpavel langpavel mentioned this pull request Apr 22, 2016
Closed
koistya
koistya reviewed Apr 22, 2016
View reviewed changes
package.json
"front-matter": "2.0.7",
"graphiql": "0.7.0",
"graphql": "0.5.0",
"history": "2.1.0",
"history": "2.0.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems like this branch is a little behind the master.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh sorry, my bad.. I'm fixing this now..

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Never mind, I will merge the master into it in a moment.

Copy link
Collaborator Author

@langpavel langpavel Apr 22, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging master will not help..
I done some weird rebasing against redux and master branch and this is badly copied file. Grrr 🎱

@koistya koistya merged commit 1ab3873 into kriasoft:feature/react-intl Apr 22, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
branch feature/react-intl
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@langpavel @koistya