Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prevent config to be bundled in client. #633

Closed
wants to merge 1 commit into from
Closed

Prevent config to be bundled in client. #633

wants to merge 1 commit into from

Conversation

langpavel
Copy link
Collaborator

No description provided.

@langpavel langpavel mentioned this pull request Apr 28, 2016
Closed
@langpavel
Copy link
Collaborator Author

@koistya Can be safely merged to both feature branches

@koistya
Copy link
Member

koistya commented Apr 28, 2016

Thanks! I'm just thinking, is it the best approach.. another solution might be to restrict this file from being compiled in client-side bundle via webpack config..

@langpavel
Copy link
Collaborator Author

@koistya Hmm that is also possible but must be done in way that user of RSK will be correctly errored when trying to do this

@langpavel
Copy link
Collaborator Author

@koistya Do you merge this or do you prepare different solution?

@langpavel langpavel mentioned this pull request May 5, 2016
Closed
@koistya
Copy link
Member

koistya commented May 5, 2016

@langpavel give me some more time to think about it please

@fchienvuhoang
Copy link

like 💃

@fchienvuhoang
Copy link

fchienvuhoang commented May 6, 2016 •
edited
Loading

love this project, thanks so much @koistya

@langpavel
Copy link
Collaborator Author

Ok :-)

@langpavel
Copy link
Collaborator Author

@koistya Just picking this up as I see chat on gitter :-)

aaron-harvey
aaron-harvey reviewed Nov 17, 2016
View reviewed changes
src/config.js
* WARNING: Do not include this file in client build.
*/
const DO_NOT_USE_THIS_FILE_IN_CLIENT = `
Configuration file contaions sensitive information and
Copy link

@aaron-harvey aaron-harvey Nov 17, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spelling: contains

@langpavel
Copy link
Collaborator Author

@koistya, @frenzzy Any new opinion on this? I'm voting 👍

@ulani
Copy link
Member

ulani commented May 27, 2021

@langpavel thank you very much for this PR! Unfortunately, we have close it due to inactivity. Feel free to re-open it or join our Discord channel for discussion.

NOTE: The main branch has been updated with React Starter Kit v2, using JAM-style architecture.

@ulani ulani closed this May 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaron-harvey aaron-harvey aaron-harvey left review comments

Assignees

@koistya koistya

Labels
development only enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@langpavel @koistya @fchienvuhoang @ulani @aaron-harvey