Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix context.next() to throw Route not found instead of TypeError #169

Merged
merged 1 commit into from
Jul 19, 2019

Conversation

frenzzy
Copy link
Member

@frenzzy frenzzy commented Jul 19, 2019

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Fixes #168

@codecov-io
Copy link

Codecov Report

Merging #169 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #169   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           7      7           
  Lines         181    181           
  Branches       53     53           
=====================================
  Hits          181    181
Impacted Files Coverage Δ
src/UniversalRouterSync.js 100% <100%> (ø) ⬆️
src/UniversalRouter.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 10527c9...faa1726. Read the comment docs.

@frenzzy frenzzy merged commit 2261630 into kriasoft:master Jul 19, 2019
@frenzzy frenzzy deleted the context-next-404 branch July 19, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

middleware TypeError for not found routes
2 participants