Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dont use thumbnails for emoticons #1488

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

marekvospel
Copy link
Contributor

In this pull request I went over places where MxcImage is used and in case of custom emojis set isThumbnail to false, as the thumbnail generation causes emoticons to lose transparency and in some cases overall animations. (more info in #1071)

The only place I'm worried about is html_message.dart, where I'm using the following snippet: isThumbnail: (actualWidth * actualHeight) > (256 * 256). Maybe using something the data-mx-emoticon property would be more fitting?

Fixes #1071

  • Code formatting and import sorting has been done with dart format lib/ test/ and dart run import_sorter:main --no-comments
  • The commit message uses the format of Conventional Commits
  • The commit message describes what has been changed, why it has been changed and how it has been changed
  • Every new feature or change of the design/GUI is linked to an approved design proposal in an issue
  • Every new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainership

Pull Request has been tested on:

  • Android
  • iOS
  • Browser (Chromium based)
  • Browser (Firefox based)
  • Browser (WebKit based)
  • Desktop Linux
  • Desktop Windows
  • Desktop macOS

@krille-chan
Copy link
Owner

@marekvospel looks good to me :) thank you very much for your contribution. It looks like your commit is not correctly signed yet. Can you sign your commit? According to the policy only signed commits can go into the main branch. More info on that you can find here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

@marekvospel
Copy link
Contributor Author

@marekvospel looks good to me :) thank you very much for your contribution. It looks like your commit is not correctly signed yet. Can you sign your commit? According to the policy only signed commits can go into the main branch. More info on that you can find here: https://docs.github.com/en/authentication/managing-commit-signature-verification/signing-commits

Will do, I just forgot the -S flag. 😅

Copy link
Owner

@krille-chan krille-chan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Thank you so much <3

@krille-chan krille-chan merged commit a4c0bd8 into krille-chan:main Nov 20, 2024
6 checks passed
@marekvospel marekvospel deleted the no-unnecessary-thumbnail branch November 20, 2024 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Animated emojis do not work
2 participants