fix: dont use thumbnails for emoticons #1488
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this pull request I went over places where
MxcImage
is used and in case of custom emojis setisThumbnail
to false, as the thumbnail generation causes emoticons to lose transparency and in some cases overall animations. (more info in #1071)The only place I'm worried about is
html_message.dart
, where I'm using the following snippet:isThumbnail: (actualWidth * actualHeight) > (256 * 256)
. Maybe using something thedata-mx-emoticon
property would be more fitting?Fixes #1071
dart format lib/ test/
anddart run import_sorter:main --no-comments
Every new feature or change of the design/GUI is linked to an approved design proposal in an issueEvery new feature in the app or the build system has a strategy how this will be tested and maintained from now on for every release, e.g. a volunteer who takes over maintainershipPull Request has been tested on: