Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] :Want to Add signin with google button #429

Closed
nishant0708 opened this issue Jun 24, 2024 · 24 comments · Fixed by #454
Closed

[FEATURE] :Want to Add signin with google button #429

nishant0708 opened this issue Jun 24, 2024 · 24 comments · Fixed by #454
Assignees
Labels
feature Adding new feature on top of the existing code

Comments

@nishant0708
Copy link

Description

want to add signin with google button

Use Case

it will make login /signup easier

Proposed Solution

No response

Additional Information

No response

Attachments

No response

@nishant0708 nishant0708 added the feature Adding new feature on top of the existing code label Jun 24, 2024
@krishnaacharyaa
Copy link
Owner

Okay go ahead @nishant0708 UI is already in place you have to uncomment, just take care of the backend

Copy link

Hey @nishant0708 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

@krishnaacharyaa
Copy link
Owner

@nishant0708 working?

@NirbhaySingh74
Copy link

i want to work on it but i am facing problem in redis and not able to connect mongodb locally??

@nishant0708
Copy link
Author

Yes I am I will raise pr by tomorrow

@siddharthisrani
Copy link
Contributor

Hii @krishnaacharyaa can i add the Google login Button?

@krishnaacharyaa
Copy link
Owner

@siddharthisrani google button UI is already in place but commented out, let me know if you want to integrate by working backend

@siddharthisrani
Copy link
Contributor

@krishnaacharyaa Yes, I would like to work on integrating the backend for this feature.

Copy link

Hey @siddharthisrani 🎉! Thanks for jumping on this issue. Before you dive in, please check out our contributing guidelines to ensure we're all on the same page. Happy coding! 🚀

@krishnaacharyaa
Copy link
Owner

@siddharthisrani how far are we?

@siddharthisrani
Copy link
Contributor

@krishnaacharyaa Yes added the login functionality with google , working good but need to change in Header.tsx so that it show the CreatePost and Logout buttons ... And want to Ask that can i change Link Tag into button tag? the "to" path is creating problem for me

@krishnaacharyaa
Copy link
Owner

And want to Ask that can i change Link Tag into button tag? the "to" path is creating problem for me

If there is no visual changes, go ahead ... but give little more efforts to see if it is possible using Link alone
@siddharthisrani

@siddharthisrani
Copy link
Contributor

Hii @krishnaacharyaa

  1. I stuck on one thing that when i login with Google and try to click on Create post it navigates me to sign page says Unautherised .
  2. Second should i Create new schema model for Google user Because i need to make some field Required False.

@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented Jul 2, 2024

I stuck on one thing that when i login with Google and try to click on Create post it navigates me to sign page says Unautherised .

It's because of not providing acces_token, figure out why it is saying unauthorized and give it the token , for that you will have to first create a token, while signing up

to make some field Required False.

What is that field, and why do you need to mark it as false?

@siddharthisrani
Copy link
Contributor

siddharthisrani commented Jul 3, 2024

Hii @krishnaacharyaa Fields are FullName, username and Password because Google login doesnt contain these field for This i have to make new seperate Schema for Google login user

@krishnaacharyaa
Copy link
Owner

@Sukomal07 can you please validate this

@Sukomal07
Copy link
Contributor

@siddharthisrani I think the new schema is not required for Google login. Make passwords optional, and one thing can you implement Google Login with Passport. js

@siddharthisrani
Copy link
Contributor

@Sukomal07 Implemented with Passport only ! before i was doing with express-session now tried with token too still getting issue ,new issue was It loads infinte after clicking on Create Post... @krishnaacharyaa I am starting from Scratch now .

@krishnaacharyaa
Copy link
Owner

@siddharthisrani any progress?

@siddharthisrani
Copy link
Contributor

@krishnaacharyaa Stuck on other work and was waiting for your reply...Starting from today apology for the delay.

@krishnaacharyaa
Copy link
Owner

was waiting for your reply

What reply where you waiting? I just didn't acknowledge, saw this message

@krishnaacharyaa I am starting from Scratch now .

What reply did it demand? am i missing something? It was a statement

@siddharthisrani
Copy link
Contributor

@krishnaacharyaa I was waiting for your comformation too , their was a quite missunderstanding and i was engaged with other project.

@krishnaacharyaa
Copy link
Owner

You are doing it now ? @siddharthisrani or how is it

@siddharthisrani
Copy link
Contributor

@krishnaacharyaa Yes i am working on it.

siddharthisrani added a commit to siddharthisrani/wanderlust that referenced this issue Jul 20, 2024
siddharthisrani added a commit to siddharthisrani/wanderlust that referenced this issue Jul 21, 2024
siddharthisrani added a commit to siddharthisrani/wanderlust that referenced this issue Jul 23, 2024
siddharthisrani added a commit to siddharthisrani/wanderlust that referenced this issue Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Adding new feature on top of the existing code
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants