Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create greetings.yaml #231

Closed
wants to merge 1 commit into from
Closed

Conversation

sanmarg
Copy link

@sanmarg sanmarg commented May 13, 2024

Added for #228

Copy link

vercel bot commented May 13, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 6:39pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 13, 2024 6:39pm

@krishnaacharyaa
Copy link
Owner

krishnaacharyaa commented May 14, 2024

Hi Mate, you are missing lots of places, please slow down and give attention to detail

  1. PR description and commit guidelines is not being followed
image

Chat gpt /bard gives me this ... You have greeting template going not sure how this is greeting, it is mostly a warning message, I don't want to greet anyone tbh.
3. Please test it before doing a PR.
4. You have it for pull request open even, which is not ideal.

@Mayur-666 please take care of this use case, it will be challenging but high need #230, test it in your other project and then raise the PR. Because this is the need, I'll revise the acceptance criteria soon for this issue....

@Mayur-666
Copy link
Contributor

@krishnaacharyaa I have this one in mind

name: 'Greetings'

on:
fork:
push:
branches: [main]
issues:
types: [opened]
pull_request_target:
types: [opened]

jobs:
welcome:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- name: Welcome Issue
if: github.event_name == 'issues'
uses: EddieHubCommunity/gh-action-community/src/welcome@main
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
issue-message: |
Congratulations, @${{ github.actor }}! 🎉
Thank you for creating your issue. Your contribution is greatly appreciated and we look forward to working with you to resolve the issue. Keep up the great work!
We will promptly review your issue and offer feedback.
Kindly remember to check our [contributing guidelines(https://github.com/krishnaacharyaa/wanderlust/blob/main/.github/CONTRIBUTING.md)
- name: Welcome Pull Request
if: github.event_name == 'pull_request_target'
uses: EddieHubCommunity/gh-action-community/src/welcome@main
with:
github-token: ${{ secrets.GITHUB_TOKEN }}
pr-message: |
Great job, @${{ github.actor }}! 🎉
Thank you for submitting your pull request. Your contribution is valuable and we appreciate your efforts to improve our project.
We will promptly review your changes and offer feedback.
Kindly remember to check our contributing guidelines

@Mayur-666
Copy link
Contributor

@krishnaacharyaa It will be something like this / or we can do some changes in message

Screenshot (537)

@krishnaacharyaa
Copy link
Owner

@krishnaacharyaa It will be something like this / or we can do some changes in message

Screenshot (537)

LGTM, we'll change the message, not getting if it is the issue wala or the PR wala... ig you wantedly just tried both the things
Lets focus on the PR raised github action first... and if @sanmarg doesn't reply quick enough post #230 issue you can take others in the sequence as well.

In #230 there are many other factors, written neatly in the acceptance criteria, can you kindly look into that.
You can raise 1 by 1 I'm fine with that...
I just need those acceptance criteria to be fullfilled... Shall we now work on that then?

@krishnaacharyaa
Copy link
Owner

@Mayur-666

@Mayur-666
Copy link
Contributor

Yes sure @krishnaacharyaa

@krishnaacharyaa
Copy link
Owner

ig you have picked it from here Sanchitbajaj02/palettegram#306
Thats good, we need to check what are others upto,

He has used some bots in the PR as well, can you look into that? And see if even we can leverage that kinda thing.
Very similar to what we are looking for
@Mayur-666

@Mayur-666
Copy link
Contributor

well i have taken it from swapnil, he's my friend and we made that at time of social summer of code.

@krishnaacharyaa
Copy link
Owner

@Mayur-666 Then I guess this guy has taken from swapalin aswell 😂😂
Well it's never a problem for me ...
I'm happy to know you are part of the root thing or closely related ...
I thoo copy from everywhere possibly and do it ☺️. That's how we all learn

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants