fix-#270 : Modified the skeleton-card(blog post) background color, added border, rounded image to the left rounded #286
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
rushil-b-patel
changed the title
rushil-b-patel
changed the title
Crazy commit. and in new PR kindly add dark theme images as well in the description Closing this as it doesn't follow the contributing guidelines |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Added background-color, border, & change the rounded image to left rounded
Description
In the dark mode there is different background color for the card that represents the blog post but for the light mode it blends with white background, so changed the background color to slate-50 with border to differentiate it from the white background. After doing that the rounded image wan't looking a good fit so changed to rounded left to make it looks nice.
Images
Before:
After:
Issue(s) Addressed
Closes #270
Prerequisites