Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix-#77:Refactor Form Validation with react-hook-form & zod #296

Closed
wants to merge 5 commits into from
Closed

fix-#77:Refactor Form Validation with react-hook-form & zod #296

wants to merge 5 commits into from

Conversation

ShristiSharan
Copy link

Summary

This PR address
1.Validation schema modification
2.Form validation logic enhancement
3. Image selection Improvements

Description

Added react hook form and zod which helps in validating the input fields and to show the error as user fills the required input field rather than showing error after complete submission.
The validation schema has been updated to include checks for the author's name length and the maximum number of selected categories, image selection, blog title length and description of blog to be posted.

Users now have the option to select an image for their blog post either by providing a URL or uploading a file from their device. Additionally, feedback is provided to the user upon image selection.

Images

Helping user to fill the input as per requirement beforehand:

image

and once corrected, error gets removed-
image

Issue(s) Addressed

Closes #77

Prerequisites

Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ❌ Failed (Inspect) May 22, 2024 4:42am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 22, 2024 4:42am

@krishnaacharyaa
Copy link
Owner

image

Build is failing because of above

Kindly make sure you follow everything from the previous PR thread, let's finish this asap. Its too much time passed...
#254

Mainly
The error messages and validations
Video showing the implementation
All the review comments of #254

@krishnaacharyaa
Copy link
Owner

Kindly rebase for the PR title checker to pass

@krishnaacharyaa
Copy link
Owner

@ShristiSharan you can delete the package-lock.json and then do npm install that should ideally solve the build failure

@ShristiSharan
Copy link
Author

okh sir, will do this asap

@ShristiSharan
Copy link
Author

@ShristiSharan you can delete the package-lock.json and then do npm install that should ideally solve the build failure

Still not working!

@krishnaacharyaa
Copy link
Owner

@ShristiSharan please arrange a call, may be tomorrow night. It is most needed, and it is quite delayed now

Copy link

Hello ShristiSharan Thank you for your PR. Unfortunately, it doesn't meet our quality checks.

Please ensure you follow our contribution guidelines. The PR title should match the required format.

For example, it should be like: fix-#124: Added responsiveness to the Home page screen.

If you have any query kindly check our contributor guidelines.

@github-actions github-actions bot closed this May 22, 2024
@ShristiSharan
Copy link
Author

@ShristiSharan please arrange a call, may be tomorrow night. It is most needed, and it is quite delayed now

Ohk Sir!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor Form vailidation using the react-hook-form and zod
2 participants