Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated README.md #304

Closed
wants to merge 7 commits into from
Closed

Conversation

Meetjain1
Copy link
Contributor

Summary

updated readme.md

Issue(s) Addressed

closes #263

updated readme.md
Copy link

vercel bot commented May 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:28pm
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 20, 2024 6:28pm

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All left aligned please.
And make sure every emojis are bouncing and animated if possible like the open source wala muscle
And instead of :- make it :

There are other content changes, i'll let you know after some time may be tomorrow @Meetjain1

@Meetjain1
Copy link
Contributor Author

All left aligned please. And make sure every emojis are bouncing and animated if possible like the open source wala muscle And instead of :- make it :

There are other content changes, i'll let you know after some time may be tomorrow @Meetjain1

sure

@Meetjain1
Copy link
Contributor Author

All left aligned please. And make sure every emojis are bouncing and animated if possible like the open source wala muscle And instead of :- make it :

There are other content changes, i'll let you know after some time may be tomorrow @Meetjain1

done with these changes ,let me know about the other changes @krishnaacharyaa

@krishnaacharyaa
Copy link
Owner

image

Can we add contributing guidelines even here?

Copy link
Owner

@krishnaacharyaa krishnaacharyaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some minor changes

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
@krishnaacharyaa
Copy link
Owner

And discord link is invalid

changed accoding to the changes requests.
@Meetjain1
Copy link
Contributor Author

Meetjain1 commented May 20, 2024

@krishnaacharyaa have a look now , I think I have completed all the changes you want .
and it is ready to merge and to get level3 and gssoc label .😄

@Meetjain1
Copy link
Contributor Author

image

Can we add contributing guidelines even here?

I dont think that we can do this by editing readme.md file

@krishnaacharyaa
Copy link
Owner

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

@krishnaacharyaa
Copy link
Owner

Why is there some space in the right side not used in the contributions section? can we make it a little small, only a little @Meetjain1

@Meetjain1
Copy link
Contributor Author

Why is there some space in the right side not used in the contributions section? can we make it a little small, only a little @Meetjain1

okk done

@Meetjain1
Copy link
Contributor Author

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ?

@krishnaacharyaa
Copy link
Owner

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ?

No we'll have to figure out, the gssoc has deployed our project in their some website, that link we'll have to put or else if you feel link mei doesn't look good.

Convert the existing description like table of 2 columns ,
GSSOC logo | description

logo should span across 2 rows got it? @Meetjain1

@Meetjain1
Copy link
Contributor Author

Looks very nice, GSSoC label , i am thinking can we make it little revealing? may be adding it in the important links? what do you feel and how about having 🔗 than gem in the links emoji section @Meetjain1

adding that jam of link , but gssoc label important links mai hmm.. ok link kaunsi du gssoc mai ? gssoc 24 ki ?

No we'll have to figure out, the gssoc has deployed our project in their some website, that link we'll have to put or else if you feel link mei doesn't look good.

Convert the existing description like table of 2 columns , GSSOC logo | description

logo should span across 2 rows got it? @Meetjain1

okk done created a table

updated as per requests
@Meetjain1
Copy link
Contributor Author

@krishnaacharyaa have a look now , I think no changes required now 🙃

@krishnaacharyaa
Copy link
Owner

@Meetjain1 , the link wala why did you change? I am not able to click anything?

The previous one the content was all good, the blue underline and proper links and stuff,

I wanted you to just change the heading from 💎 to 🔗. Rest all looks really good.
Once this is done. kindly raise fresh PR which follows contributing guidelines, so that i can close this as soon as possible. so that you get your points.

@Meetjain1
Copy link
Contributor Author

Meetjain1 commented May 20, 2024

@Meetjain1 , the link wala why did you change? I am not able to click anything?

The previous one the content was all good, the blue underline and proper links and stuff,

I wanted you to just change the heading from 💎 to 🔗. Rest all looks really good. Once this is done. kindly raise fresh PR which follows contributing guidelines, so that i can close this as soon as possible. so that you get your points.

arae mujhe laga aap ye change krne ko bole thae
you can click on that link vaala emoji in this case to get links

@krishnaacharyaa
Copy link
Owner

The previous one was good bro! Blue underline just heading Kindly change

Once you raise new PR which follows the contributing guidelines I'll merge this

Even I'm eager to get this changes in 😍😊

No more changes hopefully @Meetjain1

@Meetjain1
Copy link
Contributor Author

The previous one was good bro! Blue underline just heading Kindly change

Once you raise new PR which follows the contributing guidelines I'll merge this

Even I'm eager to get this changes in 😍😊

No more changes hopefully @Meetjain1

Haash ok 👍

completed
@Meetjain1
Copy link
Contributor Author

@krishnaacharyaa pr title checker ka issue aaraha hai kya hai ye ?

@krishnaacharyaa
Copy link
Owner

@Meetjain1 slow down your horses, 5th time I'm saying take your time and raise new PR reading the 5 points in contributing guidelines.

Once your PR follows the commits and PR title according to guidelines will merge this.

@krishnaacharyaa
Copy link
Owner

@Meetjain1 pardon me, missed the new PR!. Closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Readme.md file can be more fascinating
2 participants