Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

core-#177: Added the eslint in the husky #337

Closed
wants to merge 13 commits into from
Closed

core-#177: Added the eslint in the husky #337

wants to merge 13 commits into from

Conversation

Ameerjafar
Copy link
Contributor

Summary

i have added the eslint in the husky folder

Description

initially we have the commit regex and prettier in the husky now I added the airbnb eslint in the husky

Issue(s) Addressed

Enter the issue number of the bug(s) that this PR fixes

Prerequisites

Copy link

vercel bot commented May 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
wanderlust ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 11:22am
wanderlust-backend ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 23, 2024 11:22am

Copy link

Thank you @Ameerjafar! Your PR title meets our guidelines.

@krishnaacharyaa
Copy link
Owner

@Ameerjafar pardon me, after research figured out that lets not use the airbnb, lets use the prettier:recommend and eslint:recommended.

Kindly make sure that we use the best configuration out of https://fullstackopen.com/en/part3/validation_and_es_lint#lint
In next PR lets make sure that we run the eslint --fix in one PR, so that we don't mix it with this PR.

Copy link

Thank you @Ameerjafar! Your PR title meets our guidelines.

@Ameerjafar
Copy link
Contributor Author

@krishnaacharyaa can you kindly check now sir.

@krishnaacharyaa krishnaacharyaa changed the title core-#177: Added the eslint in the husky chore-#177: Added the eslint in the husky May 22, 2024
Copy link

Hey @krishnaacharyaa! Thank you for going through the contributing guidelines. Give Krishna sometime, I hope he'll show up 😜

@krishnaacharyaa krishnaacharyaa changed the title chore-#177: Added the eslint in the husky core-#177: Added the eslint in the husky May 22, 2024
Copy link

Hey @krishnaacharyaa! Hold your horses 🐴! Thanks for your PR, but we have some style rules around here. Your PR title doesn't quite cut the mustard.

Make sure you follow our contribution guidelines: PR titles should look like fix-#124: Added responsiveness to the Home page screen.

Check out our contributor guidelines for more details. Fix it up, and I'll be happy to take another look 😉.

@krishnaacharyaa krishnaacharyaa changed the title core-#177: Added the eslint in the husky chore-#177: Added the eslint in the husky May 22, 2024
Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

@krishnaacharyaa krishnaacharyaa changed the title core-#177: Added the eslint in the husky chore-#177: Added the eslint in the husky May 23, 2024
Copy link

Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻

@krishnaacharyaa krishnaacharyaa changed the title chore-#177: Added the eslint in the husky core-#177: Added the eslint in the husky May 23, 2024
Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

Copy link

Hey @krishnaacharyaa! Thanks for sticking to the guidelines! High five! 🙌🏻

@krishnaacharyaa krishnaacharyaa changed the title chore-#177: Added the eslint in the husky core-#177: Added the eslint in the husky May 23, 2024
Copy link

Umm... did someone forget to read the style guide? Fix that PR title and let's try again! @krishnaacharyaa
Don't worry, it happens to the best of us! Check out our contributor guidelines for more details.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ENHANCEMENT] Add husky in the project
2 participants