fix-#379: Enhancing the footer by including GitHub and Discord for better feedback #430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Discord for better feedback
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Hey @Lanthoiba2022! Thanks for sticking to the guidelines! High five! 🙌🏻 |
krishnaacharyaa
requested changes
Jun 25, 2024
There was a problem hiding this comment.
Thank you @Lanthoiba2022 for the PR, and for the patience to follow all the guidelines, much appreciated
Kindly address the review comments
| <span> | ||
| <a href="https://github.com/krishnaacharyaa/wanderlust"> | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" |
There was a problem hiding this comment.
Please extract this out to a different svg file and then import like other svg files in the project
| <a href="https://discord.com/invite/FEKasAdCrG"> | ||
| <svg | ||
| xmlns="http://www.w3.org/2000/svg" | ||
| className="h-6 w-10" |
| <section className="mt-4 flex items-center pl-16 text-xs"> | ||
| <span className="mr-2">©</span> | ||
| {year} All Rights Reserved | ||
| </section> |
There was a problem hiding this comment.
year is taken using this method "const year = newDate.getFullYear();". Ig it's not to be hardcoded.
There was a problem hiding this comment.
Oh okay, sorry missed it
…ter by including GitHub and Discord for better feedback
krishnaacharyaa
approved these changes
Jun 25, 2024
| <section className="mt-4 flex items-center pl-16 text-xs"> | ||
| <span className="mr-2">©</span> | ||
| {year} All Rights Reserved | ||
| </section> |
There was a problem hiding this comment.
Oh okay, sorry missed it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Enhancing the footer by including GitHub and Discord for better feedback
Description
Added GitHub clickable icon which will take the person to GitHub for raising issue if any and
Discord clickable icon to connect with the community if desire.
Images
Before
After
Issue(s) Addressed
#379
Prerequisites