Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Incorrect event name logging when subscribing with :with option #217

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

qoosuperman
Copy link

@qoosuperman qoosuperman commented Sep 23, 2024

Fixes #215:

Issue Description

when using LoggerBroadcaster, the message flow is as follows::
image

The method_to_call argument passed from ObjectRegistration to Broadcasters::LoggerBroadcaster is incorrectly interpreted as the event name in the logging, resulting in incorrect logged information.

Solution

This PR ensures that ObjectRegistration / LoggerBroadcaster correctly handles the event and method_to_call argument

Note: Although Broadcasters::SendBroadcaster#broadcast does not require the event argument and only needs the method_to_call argument, all broadcasters are designed to have a consistent #broadcast method interface. Therefore, they should share the same argument structure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect event name logging with :with option in Wisper event broadcasting
1 participant