- Fix: Change expected newVersion on blocked event per spec
#2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brettz9
added a commit
to brettz9/IndexedDBShim
that referenced
this pull request
Apr 14, 2017
signature, `dbName` for force-closing databases of a particular name
- Add missing API: `versionchange` and `blocked` events (currently assumes
single process); addresses indexeddbshim#2
- Fix: Close connection on abort (setting closed flag)
- Fix: Have `deleteDatabase` empty relevant `connections` (relevant
for `__forceClose` as well as `open`)
- Refactoring: Rename `transformW3CStack.js` to `transformV8Stack.js`
- Refactoring: Move excluded files into good-bad files file
- Testing (W3C Old): Partly update `TransactionBehavior.js` tests to
ensure `objectStoreNames` are compared as arrays
- Testing (Mocha): For now, make exception for Chrome as with other
browsers to `window.onerror` tests in `IDBTransaction/events-spec.js`
but keep note in testing list
- Testing (mock): Fix for `blocked` event's expected `newVersion` (submitted
fix as <kristofdegrave/indexedDBmock#2>)
IndexedDB Test counts:
323 normal files (including 1 domstringlist file):
315 are all good, 3 have some that are bad,
5 have some that time out and 3 have some that do not run
7 excluded files (uncaught exceptions during testing):
`bindings-inject-key.js`,
`keypath-exceptions.js`,
'event-dispatch-active-flag.js',
'fire-error-event-exception.js',
'fire-success-event-exception.js',
'fire-upgradeneeded-event-exception.js'
'upgrade-transaction-deactivation-timing.js'
Current IndexedDB (and domstringlist) test statuses (vmTimeout = 40000):
'Pass': 1168, (including 4 domstringlist tests but avoiding exclusions)
'Fail': 6,
'Timeout': 5,
'Not Run': 3,
'Total tests': 1182 (including 4 domstringlist tests but avoiding exclusions)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
http://w3c.github.io/IndexedDB/#opening
Relevant portions of spec:
and