Discard very large buffers, they just cause problems, #132

kriszyp · Mar 10, 2024 · 2550f79 · 2550f79
1 parent 288a906
commit 2550f79
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/pack.js b/pack.js
@@ -189,10 +189,14 @@ export class Packr extends Unpackr {
 								return packr.pack(value, encodeOptions)
 							}
 							packr.lastNamedStructuresLength = sharedLength
+							// don't keep large buffers around
+							if (target.length > 0x40000000) target = null
 							return returnBuffer
 						}
 					}
 				}
+				// don't keep large buffers around, they take too much memory and cause problems (limit at 1GB)
+				if (target.length > 0x40000000) target = null
 				if (encodeOptions & RESET_BUFFER_MODE)
 					position = start
 			}