Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add support for deno ? #25

Closed
gcxfd opened this issue May 1, 2021 · 6 comments
Closed

add support for deno ? #25

gcxfd opened this issue May 1, 2021 · 6 comments

Comments

@gcxfd
Copy link

gcxfd commented May 1, 2021

deno is very good , can I use msgpackr in deno ?

@kriszyp
Copy link
Owner

kriszyp commented May 2, 2021

This seems like a good idea. It is worth noting that deno doesn't have support for native modules, so the performance boost from msgpackr-extract wouldn't be available. But, I still could change the modules to be ESM modules (especially since Node 10 is EOL now), so they would work in Deno.

@gcxfd
Copy link
Author

gcxfd commented May 6, 2021

https://deno.land/manual/getting_started/webassembly
https://www.secondstate.io/articles/deno-webassembly-rust-wasi/
if need speed , deno can use rust & webassembly , but I think ESM modules is enough for use

@kriszyp
Copy link
Owner

kriszyp commented May 6, 2021

Yes, I am working on it!

kriszyp added a commit that referenced this issue May 14, 2021
@kriszyp
Copy link
Owner

kriszyp commented May 14, 2021

I have fully upgraded msgpackr to using ESM format for all modules now, so all the modules (at least the ones that aren't specific to node streams) should be available for use in Deno (you could reference through standard git protocol):
https://raw.githubusercontent.com/kriszyp/msgpackr/master/index.js

@gcxfd
Copy link
Author

gcxfd commented May 14, 2021

thanks , you can publish it to deno.land , so more deno user can find it

https://deno.land/x

see image below

image

@gcxfd gcxfd closed this as completed May 14, 2021
@kriszyp
Copy link
Owner

kriszyp commented May 14, 2021

ok, published it, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants