-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build can't find devtools? #69
Comments
Wait, is this just because the binary for the new version of devtools isn't built on CRAN yet? |
Yes, I think this will auto-resolve tomorrow. It would work if Rtools was installed for this build, but it's not because you don't have compiled code. You can force it, but this will slow regular builds. |
Thanks so much for the response! I tried pushing commits today, and now the build can find devtools but it says that it can't install my actual package. There is a new version of my package as of Saturday but all the binaries appear to be built:
Is this because of my new version on CRAN? Do I wait longer again? Other thoughts? I appreciate your help a lot. Here is the link to AppVeyor: https://ci.appveyor.com/project/juliasilge/tidytext/ |
I've been staring at the AppVeyor logs trying to find out what is going on here because I am now waiting on AppVeyor to pass to do the GitHub release for the new version of our package. I have been comparing the last build that passed on AppVeyor: I just ran |
For some reason, the second build doesn't install the DBI package which seems necessary. The artifacts of failed builds have a zip file of the check directory. If winbuilder succeeds, I think it's ok to release to CRAN. |
Thanks so much for helping me with this! I see that dplyr imports DBI , and my package imports dplyr. I am not sure why DBI is not being installed on the AppVeyor build without me telling it specifically to do this since it is a dependency of a dependency. Is there some way for me to force the AppVeyor build to install DBI like there is on Travis?
And then whatever I want to install? Or something else you think I should try? (Just FYI, this morning I did try deleting the whole project on AppVeyor and then adding it back in, but it still failed.) |
You can call |
I just tried doing a version like this:
But it is still failing in the same spot: In the artifacts, it still says:
It looks like trying to force DBI to install did not work. There haven't been any recent updates to DBI, it looks like? Can you think of any reason why DBI is not installing? My package does not actually use any relational database systems, for the record; it only imports dplyr. |
DBI seems to be installed; could you please look into failure.zip in the artifacts section of your build to see what's wrong now? |
Ah, you are right; I was looking in the wrong directory before. Apologies! I have gone through and added manually via These are all dependencies of dplyr, which just had a new version released. It looks like the dependencies of dplyr are no longer getting installed correctly since the new release. |
I had the idea to try manually installing dplyr via
So it seems like it is failing to install the packages that my package's dependencies depend on, if that makes sense. When I look at the console of the latest build, for example, it is installing the direct dependencies but not the ones one level back. |
I was playing around with this a bit more today, and I got my package to build on appveyor by installing via
I added these, one at a time, after seeing which dependency one level back was missing (for example, gtable for ggplot2, psych for broom, etc). My package is building successfully on AppVeyor now, but this isn't right, correct? Something is not behaving as it is supposed to with installing dependencies? |
Looks like this is a devtools problem after all: r-lib/devtools#1246. I'll keep this open, because r-appveyor temporarily might want to install devtools from GitHub. |
What is the status of this? Will r-appveyor (temporarily) install devtools from GitHub? Or is there a way for me to request that in my own appveyor.yml? I might not have @juliasilge's patience to develop the list of dependencies with dependencies for manual installation! |
In case it's useful to anyone else while this situation sorts itself out, @jimhester showed me how to direct appveyor to grab
This, in turn, requires that Rtools be present, so to force installation, even in the absence of a
|
A general solution for this issue would be fine. Currently I'm adding one package after the other to the import session of the DESCRIPTION file to run AppVeyor. But this way and the other ones the previous posts are only workarounds. Btw.: I have the same problem on my local PC. For me it looks like a general issue with Windows. |
@surmann For your local problem, is it not fixed by installing |
@jennybc Unfortunately not on my local Windows PC. I now use |
@surmann There is already an issue for this r-lib/devtools#1265 and it should be fixed with the latest devtools. Make sure to restart your R session after installing devel devtools before testing. |
@jimhester Obviously, it was a missed restart. Thanks for your hint. |
Thanks a lot @jennybc and @jimhester, the changes to appveyor.yml above have allowed me to successfully build one of my current projects in appveyor and to uncover a bug in the Windows build of another project. |
Thanks for your insights. @jennybc @jimhester: I thought installing devtools from GitHub on a Windows machine requires some special action. I'm just surprised this code works. Obviously, the easiest "fix" is to release devtools to CRAN. An alternative is to put a binary build of a properly working devtools version somewhere on the web, and have r-appveyor install devtools specifically from there by default. (A drat repository would be the super-luxury variant.) @jimhester: What do you suggest? |
@krlmlr |
@surmann: That's a workaround, but actually everything should work "out of the box". |
@krlmlr That´s right. However, this is the only way it works currently on a windows machine. |
@surmann: I'm aware of this, and I'd like to help change the state of affairs. |
I talked with @hadley about a small devtools release, it sounds like it might be hard to squeeze in in the immediate future. We could add a step to the devtools appveyor.yml that puts the latest windows binary in the github releases for r-appveyor after the build succeeds. Of course that would require devtools to successfully build on appveyor (which is currently does not due to this issue 😉). We would have to expand the build matrix in the devtools appveyor to build on release, devel and old-release to support all versions of appveyor as well. I don't believe drat repositories provide binary builds, so we would have to do something custom for this use case if we went that route. |
If this is a regression, I could just grab an older devtools release from CRAN by default.? |
That is true, might be the simplest solution for now On Jul 29, 2016 10:34 AM, "Kirill Müller" notifications@github.com wrote:
|
Do you know, by chance, which version would work best? |
1.11.1 should work fine. CRAN only keeps sources from previous versions of packages, however there is a binary for R-3.1 at https://cran.r-project.org/bin/windows/contrib/3.1/devtools_1.11.1.zip which you could try. I wouldn't be surprised if it breaks though. |
I've pushed a fix to the r-travis project that installs a custom version of devtools (krlmlr/devtools@c6387931a37dc, current master with some testthat-related changes undone). The technical part seems to work, does the updated version of devtools pick up the dependencies in your packages? |
Works for me: https://ci.appveyor.com/project/jennybc/cellranger/build/1.0.37 I was able to revert to my previous appveyor.yml. |
Also works for me: https://ci.appveyor.com/project/juliasilge/tidytext/build/1.0.26 I removed the lines from my appveyor.yml that installed Rtools and that installed the GitHub version of devtools. I am up for closing this issue? Seems fixed to me? ✔️ |
Thanks to everyone for your help, I'm sorry for the pain this caused. |
Thanks, this works for me, too. |
The previous commmit failed because stringi was just updated. Temporary fix: krlmlr/r-appveyor#69 (comment)
The commits I've pushed this morning have all failed on AppVeyor; it looks like this is because it can't find devtools?
Here is the link: https://ci.appveyor.com/project/juliasilge/tidytext/build/1.0.41
There is a new version of devtools; I expect this is related somehow?
The text was updated successfully, but these errors were encountered: