Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: disable unittest temporarily for CI introduction #14

Merged
merged 1 commit into from
Feb 17, 2023
Merged

ci: disable unittest temporarily for CI introduction #14

merged 1 commit into from
Feb 17, 2023

Conversation

ray-lightscale
Copy link
Contributor

@ray-lightscale ray-lightscale commented Feb 16, 2023 •
edited
Loading

This test is failed since 68bfa8b, which is introduced by Optimism.
To introduce CI testing, we decided to skip this test for the time being.
Once we know the reason why this is failed, then we need to re-enable this test.

@ray-lightscale ray-lightscale changed the title distable test disable test Feb 16, 2023
@lightscale-github lightscale-github force-pushed the ci/test-disable branch 2 times, most recently from 195522a to c8af52c Compare February 16, 2023 09:03
@ray-lightscale ray-lightscale changed the title disable test test temporarily disable Feb 16, 2023
@chokobole chokobole changed the title test temporarily disable ci: disable unittest temporarily for CI introduction Feb 17, 2023
chokobole
chokobole approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ray-lightscale ray-lightscale merged commit d5f3f59 into dev Feb 17, 2023
@ray-lightscale ray-lightscale deleted the ci/test-disable branch February 17, 2023 01:18
chokobole added a commit that referenced this pull request Mar 8, 2023
@chokobole
kanvas: apply historical kanvas-geth rollup changes
6cf45cc 
This commit squashes the kanvas-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

See https://github.com/wemixkanvas/go-ethereum/commits/op-geth-base
for more details about how op-geth changes geth code.

kanvas-geth changes:

- Merge pull request #17 from light-scale/fix/change-contract-address
- fix: change predeployed contract address
- Merge pull request #15 from light-scale/ci/lint
- Merge pull request #16 from light-scale/ci/pipeline
- ci: add ci pipeline and test pipeline
- ci: add worklows to run lint on push
- ci: change the style of the code so that linting succeeds
- Merge pull request #14 from light-scale/ci/test-disable
- disable unittest temporarily for CI introduction
- Merge pull request #13 from light-scale/feat/enable-tx-pool-sync-by-force
- feat: enable tx pool sync by force
- Merge pull request #11 from light-scale/feat/remove-daisy-chain
- feat: remove daisy chain
- Merge pull request #10 from light-scale/feat/set-pending-block-gas-limit
- Merge pull request #12 from light-scale/zktrie
- chore: upgrade zktrie library
- feat: enable setting pending block gas limit
- chore: rename optimism to kanvas
- ci: remove circle ci config
- Merge pull request #8 from light-scale/feat/add-fee-recipients-to-proof
- feat(core, eth): add Optimism{Base,L1}FeeRecipient to block trace
- feat: add Mint to TransactionTrace
- Merge pull request #5 from light-scale/feat/add-L1CostFunc-to-EVM-BlockContext
- fix(cmd): list ipcAPIs on alphabetical order
- fix(eth): add L1CostFunc to evm's block context
- refac(light): remove unneeded member variable
- perf(trie): disable preimage by default
- chore: rename voost to kanvas
- Merge pull request #3 from light-scale/feat/enable-use-keccak-for-codehash
- feat: use poseidon as code hash only with zktrie
- fix(cmd, core): load database with Zktrie when possible
- fix: fix segfault when referencing to Database
- fix(common, signer): make unit test passed

We wrapped code with comments like below to separate code change for
scroll-geth from op-geth.

```go
// [Scroll: START]
// changes for scroll-geth
// [Scroll: END]
```

scroll-geth changes:

- Merge pull request #1 from light-scale/feat/add-scroll-patches
- chore: add run_geth.sh
- feat: add GetBlockResultByNumberOrHash rpc
- feat: add CacheConfig to Backend interface
- feat(core): add some methods to StateDB interface
- feat: add MPTWitness to CacheConfig
- feat: use zktrie for state trie
- feat: apply poseidon to codehash
- feat(core): add ReturnValue to Receipt
- feat: add detailed contents to traces for zkevm
- feat(core/vm, eth/tracers): add CaptureStateAfter hook
- feat(core/vm): disable SelfDestruct opcode
- test(cmd, internal): add custom genesis test
chokobole added a commit that referenced this pull request Mar 8, 2023
@chokobole
kanvas: apply historical kanvas-geth rollup changes
783efb6 
This commit squashes the kanvas-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

See https://github.com/wemixkanvas/go-ethereum/commits/op-geth-base
for more details about how op-geth changes geth code.

kanvas-geth changes:

- Merge pull request #17 from light-scale/fix/change-contract-address
- fix: change predeployed contract address
- Merge pull request #15 from light-scale/ci/lint
- Merge pull request #16 from light-scale/ci/pipeline
- ci: add ci pipeline and test pipeline
- ci: add worklows to run lint on push
- ci: change the style of the code so that linting succeeds
- Merge pull request #14 from light-scale/ci/test-disable
- disable unittest temporarily for CI introduction
- Merge pull request #13 from light-scale/feat/enable-tx-pool-sync-by-force
- feat: enable tx pool sync by force
- Merge pull request #11 from light-scale/feat/remove-daisy-chain
- feat: remove daisy chain
- Merge pull request #10 from light-scale/feat/set-pending-block-gas-limit
- Merge pull request #12 from light-scale/zktrie
- chore: upgrade zktrie library
- feat: enable setting pending block gas limit
- chore: rename optimism to kanvas
- ci: remove circle ci config
- Merge pull request #8 from light-scale/feat/add-fee-recipients-to-proof
- feat(core, eth): add Optimism{Base,L1}FeeRecipient to block trace
- feat: add Mint to TransactionTrace
- Merge pull request #5 from light-scale/feat/add-L1CostFunc-to-EVM-BlockContext
- fix(cmd): list ipcAPIs on alphabetical order
- fix(eth): add L1CostFunc to evm's block context
- refac(light): remove unneeded member variable
- perf(trie): disable preimage by default
- chore: rename voost to kanvas
- Merge pull request #3 from light-scale/feat/enable-use-keccak-for-codehash
- feat: use poseidon as code hash only with zktrie
- fix(cmd, core): load database with Zktrie when possible
- fix: fix segfault when referencing to Database
- fix(common, signer): make unit test passed

We wrapped code with comments like below to separate code change for
scroll-geth from op-geth.

```go
// [Scroll: START]
// changes for scroll-geth
// [Scroll: END]
```

scroll-geth changes:

- Merge pull request #1 from light-scale/feat/add-scroll-patches
- chore: add run_geth.sh
- feat: add GetBlockResultByNumberOrHash rpc
- feat: add CacheConfig to Backend interface
- feat(core): add some methods to StateDB interface
- feat: add MPTWitness to CacheConfig
- feat: use zktrie for state trie
- feat: apply poseidon to codehash
- feat(core): add ReturnValue to Receipt
- feat: add detailed contents to traces for zkevm
- feat(core/vm, eth/tracers): add CaptureStateAfter hook
- feat(core/vm): disable SelfDestruct opcode
- test(cmd, internal): add custom genesis test
chokobole added a commit that referenced this pull request Mar 8, 2023
@chokobole
kanvas: apply historical kanvas-geth rollup changes
9055a41 
This commit squashes the kanvas-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

See https://github.com/wemixkanvas/go-ethereum/commits/op-geth-base
for more details about how op-geth changes geth code.

kanvas-geth changes:

- Merge pull request #17 from light-scale/fix/change-contract-address
- fix: change predeployed contract address
- Merge pull request #15 from light-scale/ci/lint
- Merge pull request #16 from light-scale/ci/pipeline
- ci: add ci pipeline and test pipeline
- ci: add worklows to run lint on push
- ci: change the style of the code so that linting succeeds
- Merge pull request #14 from light-scale/ci/test-disable
- disable unittest temporarily for CI introduction
- Merge pull request #13 from light-scale/feat/enable-tx-pool-sync-by-force
- feat: enable tx pool sync by force
- Merge pull request #11 from light-scale/feat/remove-daisy-chain
- feat: remove daisy chain
- Merge pull request #10 from light-scale/feat/set-pending-block-gas-limit
- Merge pull request #12 from light-scale/zktrie
- chore: upgrade zktrie library
- feat: enable setting pending block gas limit
- chore: rename optimism to kanvas
- ci: remove circle ci config
- Merge pull request #8 from light-scale/feat/add-fee-recipients-to-proof
- feat(core, eth): add Optimism{Base,L1}FeeRecipient to block trace
- feat: add Mint to TransactionTrace
- Merge pull request #5 from light-scale/feat/add-L1CostFunc-to-EVM-BlockContext
- fix(cmd): list ipcAPIs on alphabetical order
- fix(eth): add L1CostFunc to evm's block context
- refac(light): remove unneeded member variable
- perf(trie): disable preimage by default
- chore: rename voost to kanvas
- Merge pull request #3 from light-scale/feat/enable-use-keccak-for-codehash
- feat: use poseidon as code hash only with zktrie
- fix(cmd, core): load database with Zktrie when possible
- fix: fix segfault when referencing to Database
- fix(common, signer): make unit test passed

We wrapped code with comments like below to separate code change for
scroll-geth from op-geth.

```go
// [Scroll: START]
// changes for scroll-geth
// [Scroll: END]
```

scroll-geth changes:

- Merge pull request #1 from light-scale/feat/add-scroll-patches
- chore: add run_geth.sh
- feat: add GetBlockResultByNumberOrHash rpc
- feat: add CacheConfig to Backend interface
- feat(core): add some methods to StateDB interface
- feat: add MPTWitness to CacheConfig
- feat: use zktrie for state trie
- feat: apply poseidon to codehash
- feat(core): add ReturnValue to Receipt
- feat: add detailed contents to traces for zkevm
- feat(core/vm, eth/tracers): add CaptureStateAfter hook
- feat(core/vm): disable SelfDestruct opcode
- test(cmd, internal): add custom genesis test
chokobole added a commit that referenced this pull request Mar 9, 2023
@chokobole
kanvas: apply historical kanvas-geth rollup changes
b5ba112 
This commit squashes the kanvas-geth fork history into a more maintainable
diff for rebasing upon upstream geth.

See https://github.com/wemixkanvas/go-ethereum/commits/op-geth-base
for more details about how op-geth changes geth code.

kanvas-geth changes:

- Merge pull request #17 from light-scale/fix/change-contract-address
- fix: change predeployed contract address
- Merge pull request #15 from light-scale/ci/lint
- Merge pull request #16 from light-scale/ci/pipeline
- ci: add ci pipeline and test pipeline
- ci: add worklows to run lint on push
- ci: change the style of the code so that linting succeeds
- Merge pull request #14 from light-scale/ci/test-disable
- disable unittest temporarily for CI introduction
- Merge pull request #13 from light-scale/feat/enable-tx-pool-sync-by-force
- feat: enable tx pool sync by force
- Merge pull request #11 from light-scale/feat/remove-daisy-chain
- feat: remove daisy chain
- Merge pull request #10 from light-scale/feat/set-pending-block-gas-limit
- Merge pull request #12 from light-scale/zktrie
- chore: upgrade zktrie library
- feat: enable setting pending block gas limit
- chore: rename optimism to kanvas
- ci: remove circle ci config
- Merge pull request #8 from light-scale/feat/add-fee-recipients-to-proof
- feat(core, eth): add Optimism{Base,L1}FeeRecipient to block trace
- feat: add Mint to TransactionTrace
- Merge pull request #5 from light-scale/feat/add-L1CostFunc-to-EVM-BlockContext
- fix(cmd): list ipcAPIs on alphabetical order
- fix(eth): add L1CostFunc to evm's block context
- refac(light): remove unneeded member variable
- perf(trie): disable preimage by default
- chore: rename voost to kanvas
- Merge pull request #3 from light-scale/feat/enable-use-keccak-for-codehash
- feat: use poseidon as code hash only with zktrie
- fix(cmd, core): load database with Zktrie when possible
- fix: fix segfault when referencing to Database
- fix(common, signer): make unit test passed

We wrapped code with comments like below to separate code change for
scroll-geth from op-geth.

```go
// [Scroll: START]
// changes for scroll-geth
// [Scroll: END]
```

scroll-geth changes:

- Merge pull request #1 from light-scale/feat/add-scroll-patches
- chore: add run_geth.sh
- feat: add GetBlockResultByNumberOrHash rpc
- feat: add CacheConfig to Backend interface
- feat(core): add some methods to StateDB interface
- feat: add MPTWitness to CacheConfig
- feat: use zktrie for state trie
- feat: apply poseidon to codehash
- feat(core): add ReturnValue to Receipt
- feat: add detailed contents to traces for zkevm
- feat(core/vm, eth/tracers): add CaptureStateAfter hook
- feat(core/vm): disable SelfDestruct opcode
- test(cmd, internal): add custom genesis test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

Assignees

@chokobole chokobole

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ray-lightscale @chokobole