Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: enable freezer_table_test.go #87

Merged
merged 1 commit into from
Mar 28, 2024

Conversation

jyc228
Copy link
Collaborator

@jyc228 jyc228 commented Mar 22, 2024

#21

I don't know if it's because the source code has changed a lot, but... For now, it passes the test.

Summary by CodeRabbit

  • Chores
    • Cleaned up commented-out code and TODOs in test files for improved code clarity.

@jyc228 jyc228 requested a review from a team March 22, 2024 07:52
Copy link

coderabbitai bot commented Mar 22, 2024

Walkthrough

The update focuses on cleaning up the codebase by eliminating unnecessary commented-out code and the TODOs linked to it within the freezer_table_test.go file. This kind of change helps in maintaining the clarity and readability of the test code, ensuring that only relevant and active test cases are present in the codebase.

Changes

File(s) Change Summary
core/rawdb/freezer_table_test.go Removed commented-out code and associated TODOs

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@jyc228 jyc228 linked an issue Mar 22, 2024 that may be closed by this pull request
@jyc228 jyc228 self-assigned this Mar 22, 2024
Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 45704c4 and 603ca6a.
Files selected for processing (1)
  • core/rawdb/freezer_table_test.go (4 hunks)
Files skipped from review due to trivial changes (1)
  • core/rawdb/freezer_table_test.go

@jyc228 jyc228 merged commit a4b1216 into dev Mar 28, 2024
2 checks passed
@jyc228 jyc228 deleted the test/op-geth-doesnt-pass-corerawdb-unittests branch March 28, 2024 05:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

op-geth doesn't pass core/rawdb unittests
4 participants