refac: rename DoDoubleXXX to DoubleImplXXX

This keeps consistency with other operations that have `DoXXX` as a private method.
kroma-network · Apr 18, 2024 · 5c7a951 · 5c7a951
1 parent 4ae6575
commit 5c7a951
Show file tree

Hide file tree

Showing 12 changed files with 28 additions and 28 deletions.
diff --git a/tachyon/math/base/rational_field.h b/tachyon/math/base/rational_field.h
@@ -115,11 +115,11 @@ class RationalField : public Field<RationalField<F>> {
     return *this;
   }
 
-  constexpr RationalField DoDouble() const {
+  constexpr RationalField DoubleImpl() const {
     return {numerator_.Double(), denominator_};
   }
 
-  constexpr RationalField& DoDoubleInPlace() {
+  constexpr RationalField& DoubleImplInPlace() {
     numerator_.DoubleInPlace();
     return *this;
   }

diff --git a/tachyon/math/base/semigroups.h b/tachyon/math/base/semigroups.h
@@ -58,7 +58,7 @@ namespace internal {
 SUPPORTS_BINARY_OPERATOR(Mul);
 SUPPORTS_UNARY_OPERATOR(SquareImpl);
 SUPPORTS_BINARY_OPERATOR(Add);
-SUPPORTS_UNARY_OPERATOR(DoDouble);
+SUPPORTS_UNARY_OPERATOR(DoubleImpl);
 
 template <typename T, typename = void>
 struct SupportsToBigInt : std::false_type {};
@@ -245,19 +245,19 @@ class AdditiveSemigroup {
 
   // a.Double(): 2a
   [[nodiscard]] constexpr auto Double() const {
-    if constexpr (internal::SupportsDoDouble<G>::value) {
+    if constexpr (internal::SupportsDoubleImpl<G>::value) {
       const G* g = static_cast<const G*>(this);
-      return g->DoDouble();
+      return g->DoubleImpl();
     } else {
       return operator+(static_cast<const G&>(*this));
     }
   }
 
   // a.DoubleInPlace(): a = 2a
   constexpr G& DoubleInPlace() {
-    if constexpr (internal::SupportsDoDoubleInPlace<G>::value) {
+    if constexpr (internal::SupportsDoubleImplInPlace<G>::value) {
       G* g = static_cast<G*>(this);
-      return g->DoDoubleInPlace();
+      return g->DoubleImplInPlace();
     } else if constexpr (internal::SupportsAddInPlace<G, G>::value) {
       return operator+=(static_cast<const G&>(*this));
     } else {
@@ -416,7 +416,7 @@ class AdditiveSemigroup {
     auto it = BitIteratorBE<BigInt<N>>::begin(&scalar, true);
     auto end = BitIteratorBE<BigInt<N>>::end(&scalar);
     while (it != end) {
-      if constexpr (internal::SupportsDoDoubleInPlace<G>::value ||
+      if constexpr (internal::SupportsDoubleImplInPlace<G>::value ||
                     internal::SupportsAddInPlace<G, G>::value) {
         ret.DoubleInPlace();
       } else {

diff --git a/tachyon/math/elliptic_curves/short_weierstrass/jacobian_point.h b/tachyon/math/elliptic_curves/short_weierstrass/jacobian_point.h
@@ -265,8 +265,8 @@ class JacobianPoint<
   constexpr JacobianPoint& AddInPlace(const JacobianPoint& other);
   constexpr JacobianPoint Add(const AffinePoint<Curve>& other) const;
   constexpr JacobianPoint& AddInPlace(const AffinePoint<Curve>& other);
-  constexpr JacobianPoint DoDouble() const;
-  constexpr JacobianPoint& DoDoubleInPlace();
+  constexpr JacobianPoint DoubleImpl() const;
+  constexpr JacobianPoint& DoubleImplInPlace();
 
   // AdditiveGroup methods
   constexpr JacobianPoint Negate() const { return {x_, -y_, z_}; }

diff --git a/tachyon/math/elliptic_curves/short_weierstrass/jacobian_point_impl.h b/tachyon/math/elliptic_curves/short_weierstrass/jacobian_point_impl.h
@@ -197,7 +197,7 @@ constexpr void CLASS::DoAdd(const JacobianPoint& a, const AffinePoint<Curve>& b,
 }
 
 template <typename Curve>
-constexpr CLASS CLASS::DoDouble() const {
+constexpr CLASS CLASS::DoubleImpl() const {
   if (IsZero()) {
     return JacobianPoint::Zero();
   }
@@ -208,7 +208,7 @@ constexpr CLASS CLASS::DoDouble() const {
 }
 
 template <typename Curve>
-constexpr CLASS& CLASS::DoDoubleInPlace() {
+constexpr CLASS& CLASS::DoubleImplInPlace() {
   if (IsZero()) {
     return *this;
   }

diff --git a/tachyon/math/elliptic_curves/short_weierstrass/point_xyzz.h b/tachyon/math/elliptic_curves/short_weierstrass/point_xyzz.h
@@ -279,8 +279,8 @@ class PointXYZZ<_Curve,
   constexpr PointXYZZ& AddInPlace(const PointXYZZ& other);
   constexpr PointXYZZ Add(const AffinePoint<Curve>& other) const;
   constexpr PointXYZZ& AddInPlace(const AffinePoint<Curve>& other);
-  constexpr PointXYZZ DoDouble() const;
-  constexpr PointXYZZ& DoDoubleInPlace();
+  constexpr PointXYZZ DoubleImpl() const;
+  constexpr PointXYZZ& DoubleImplInPlace();
 
   // AdditiveGroup methods
   constexpr PointXYZZ Negate() const { return {x_, -y_, zz_, zzz_}; }

diff --git a/tachyon/math/elliptic_curves/short_weierstrass/point_xyzz_impl.h b/tachyon/math/elliptic_curves/short_weierstrass/point_xyzz_impl.h
@@ -175,7 +175,7 @@ constexpr void CLASS::DoAdd(const PointXYZZ& a, const AffinePoint<Curve>& b,
 }
 
 template <typename Curve>
-constexpr CLASS CLASS::DoDouble() const {
+constexpr CLASS CLASS::DoubleImpl() const {
   if (IsZero()) {
     return PointXYZZ::Zero();
   }
@@ -186,7 +186,7 @@ constexpr CLASS CLASS::DoDouble() const {
 }
 
 template <typename Curve>
-constexpr CLASS& CLASS::DoDoubleInPlace() {
+constexpr CLASS& CLASS::DoubleImplInPlace() {
   if (IsZero()) {
     return *this;
   }

diff --git a/tachyon/math/elliptic_curves/short_weierstrass/projective_point.h b/tachyon/math/elliptic_curves/short_weierstrass/projective_point.h
@@ -259,8 +259,8 @@ class ProjectivePoint<
   constexpr ProjectivePoint& AddInPlace(const ProjectivePoint& other);
   constexpr ProjectivePoint Add(const AffinePoint<Curve>& other) const;
   constexpr ProjectivePoint& AddInPlace(const AffinePoint<Curve>& other);
-  constexpr ProjectivePoint DoDouble() const;
-  constexpr ProjectivePoint& DoDoubleInPlace();
+  constexpr ProjectivePoint DoubleImpl() const;
+  constexpr ProjectivePoint& DoubleImplInPlace();
 
   // AdditiveGroup methods
   constexpr ProjectivePoint Negate() const { return {x_, -y_, z_}; }

diff --git a/tachyon/math/elliptic_curves/short_weierstrass/projective_point_impl.h b/tachyon/math/elliptic_curves/short_weierstrass/projective_point_impl.h
@@ -176,7 +176,7 @@ constexpr void CLASS::DoAdd(const ProjectivePoint& a,
 }
 
 template <typename Curve>
-constexpr CLASS CLASS::DoDouble() const {
+constexpr CLASS CLASS::DoubleImpl() const {
   if (IsZero()) {
     return ProjectivePoint::Zero();
   }
@@ -187,7 +187,7 @@ constexpr CLASS CLASS::DoDouble() const {
 }
 
 template <typename Curve>
-constexpr CLASS& CLASS::DoDoubleInPlace() {
+constexpr CLASS& CLASS::DoubleImplInPlace() {
   if (IsZero()) {
     return *this;
   }

diff --git a/tachyon/math/finite_fields/cubic_extension_field.h b/tachyon/math/finite_fields/cubic_extension_field.h
@@ -172,15 +172,15 @@ class CubicExtensionField : public CyclotomicMultiplicativeSubgroup<Derived> {
     return *static_cast<Derived*>(this);
   }
 
-  constexpr Derived DoDouble() const {
+  constexpr Derived DoubleImpl() const {
     return {
         c0_.Double(),
         c1_.Double(),
         c2_.Double(),
     };
   }
 
-  constexpr Derived& DoDoubleInPlace() {
+  constexpr Derived& DoubleImplInPlace() {
     c0_.DoubleInPlace();
     c1_.DoubleInPlace();
     c2_.DoubleInPlace();

diff --git a/tachyon/math/finite_fields/prime_field_generic.h b/tachyon/math/finite_fields/prime_field_generic.h
@@ -186,7 +186,7 @@ class PrimeField<_Config, std::enable_if_t<!_Config::kIsSpecialPrime>> final
     return *this;
   }
 
-  constexpr PrimeField DoDouble() const {
+  constexpr PrimeField DoubleImpl() const {
     PrimeField ret;
     uint64_t carry = 0;
     ret.value_ = value_.MulBy2(carry);
@@ -195,7 +195,7 @@ class PrimeField<_Config, std::enable_if_t<!_Config::kIsSpecialPrime>> final
     return ret;
   }
 
-  constexpr PrimeField& DoDoubleInPlace() {
+  constexpr PrimeField& DoubleImplInPlace() {
     uint64_t carry = 0;
     value_.MulBy2InPlace(carry);
     BigInt<N>::template Clamp<Config::kModulusHasSpareBit>(Config::kModulus,

diff --git a/tachyon/math/finite_fields/quadratic_extension_field.h b/tachyon/math/finite_fields/quadratic_extension_field.h
@@ -142,14 +142,14 @@ class QuadraticExtensionField
     return *static_cast<Derived*>(this);
   }
 
-  constexpr Derived DoDouble() const {
+  constexpr Derived DoubleImpl() const {
     return {
         c0_.Double(),
         c1_.Double(),
     };
   }
 
-  constexpr Derived& DoDoubleInPlace() {
+  constexpr Derived& DoubleImplInPlace() {
     c0_.DoubleInPlace();
     c1_.DoubleInPlace();
     return *static_cast<Derived*>(this);

diff --git a/tachyon/zk/base/value.h b/tachyon/zk/base/value.h
@@ -75,12 +75,12 @@ class Value : public math::Field<Value<T>> {
     return Value::Known(*value_ + other);
   }
 
-  constexpr Value DoDouble() const {
+  constexpr Value DoubleImpl() const {
     if (IsNone()) return Unknown();
     return Value::Known(value_->Double());
   }
 
-  constexpr Value& DoDoubleInPlace() {
+  constexpr Value& DoubleImplInPlace() {
     if (IsNone()) return *this;
     value_->DoubleInPlace();
     return *this;