feat(math): add range check to string conversion methods #389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chokobole
requested review from
dongchangYoo,
Insun35,
fakedev9999 and
ashjeong
chokobole
force-pushed
the
feat/add-range-check-to-string-conversion-methods
branch
from
68c2049 to
8367c09
Compare
ashjeong
requested changes
Apr 15, 2024
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_x86.h.tpl
Outdated
Show resolved
Hide resolved
fakedev9999
reviewed
Apr 15, 2024
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_x86.h.tpl
Outdated
Show resolved
Hide resolved
fakedev9999
reviewed
Apr 15, 2024
tachyon/math/finite_fields/generator/prime_field_generator/prime_field_x86.h.tpl
Outdated
Show resolved
Hide resolved
fakedev9999
requested changes
Apr 15, 2024
tachyon/math/finite_fields/goldilocks/goldilocks_prime_field_x86_special.cc
Outdated
Show resolved
Hide resolved
tachyon/math/finite_fields/goldilocks/goldilocks_prime_field_x86_special.cc
Outdated
Show resolved
Hide resolved
chokobole
force-pushed
the
feat/add-range-check-to-string-conversion-methods
branch
from
8367c09 to
6a9ac90
Compare
While this may appear redundant in debug mode due to the existing range check in the constructor of PrimeField, we find it acceptable since `From(Dec|Hex)String` is not called frequently and the performance impact in release mode is minimal.
chokobole
force-pushed
the
feat/add-range-check-to-string-conversion-methods
branch
from
6a9ac90 to
54e801e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the following features:
BigInt<N>.PrimeFieldXXX::From(Dec|Hex)String.