Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(zk): clean up zk #393

Merged
merged 4 commits into from
Apr 18, 2024
Merged

chore(zk): clean up zk #393

merged 4 commits into from
Apr 18, 2024

Conversation

Insun35
Copy link
Contributor

@Insun35 Insun35 commented Apr 17, 2024

Fix typos in comments and cleanup BUILD files

chokobole
chokobole approved these changes Apr 17, 2024
View reviewed changes
Copy link
Contributor

@chokobole chokobole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

TomTaehoonKim
TomTaehoonKim approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@TomTaehoonKim TomTaehoonKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ashjeong
ashjeong approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

dongchangYoo
dongchangYoo approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dongchangYoo dongchangYoo merged commit 2c6c4c4 into main Apr 18, 2024
3 checks passed
@dongchangYoo dongchangYoo deleted the chore/clean-up-zk branch April 18, 2024 14:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chokobole chokobole chokobole approved these changes

@dongchangYoo dongchangYoo dongchangYoo approved these changes

@TomTaehoonKim TomTaehoonKim TomTaehoonKim approved these changes

@ashjeong ashjeong ashjeong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Insun35 @chokobole @dongchangYoo @TomTaehoonKim @ashjeong