Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(math): prepare poseidon2 #411

Merged
merged 7 commits into from
May 8, 2024
Merged

feat(math): prepare poseidon2 #411

merged 7 commits into from
May 8, 2024

Conversation

chokobole
Copy link
Contributor

Description

This PR prepares for Poseidon2 Hash function. In Poseidon2, the Matirx for the Internal Round is a diagonal matrix. So this PR mainly adds DiagonalMatrix. Additionally, it adds minor improvements on Matrix types.

@chokobole chokobole force-pushed the feat/prepare-poseidon2 branch 2 times, most recently from 1065777 to 3f48769 Compare May 2, 2024 05:37
tachyon/math/matrix/matrix_types.h Show resolved Hide resolved
tachyon/math/matrix/matrix_types.h Show resolved Hide resolved
tachyon/math/matrix/matrix_types.h Outdated Show resolved Hide resolved
@chokobole chokobole force-pushed the feat/prepare-poseidon2 branch from 3f48769 to c4918d5 Compare May 2, 2024 08:27
Copy link
Contributor

@fakedev9999 fakedev9999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the feat/prepare-poseidon2 branch from c4918d5 to 9a4de77 Compare May 2, 2024 09:54
Copy link
Contributor

@Insun35 Insun35 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@dongchangYoo dongchangYoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole force-pushed the feat/prepare-poseidon2 branch from 9a4de77 to 8fcca55 Compare May 8, 2024 07:42
@chokobole chokobole force-pushed the feat/prepare-poseidon2 branch from 8fcca55 to a7a6b7b Compare May 8, 2024 08:48
Copy link
Contributor

@ashjeong ashjeong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chokobole chokobole merged commit b167be4 into main May 8, 2024
3 checks passed
@chokobole chokobole deleted the feat/prepare-poseidon2 branch May 8, 2024 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants